[SelectionDAG] cheri-inefficient diag is also about source #801
+29
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This warning is a bit dodgy anyway, it gives a bunch of false positives and shouldn't really be a warning at all when it does fire given it's in the backend (maybe an optimisation remark if anything?). The test suite is failing because clang/test/CodeGen/cheri/memcpy-unaligned.c checks the warning that gets emitted, and warn_cheri_memintrin_misaligned_inefficient has a copy of this warning message (though I don't think it's actually used). |
Flowdalic
force-pushed
the
cheri-inefficient-source-cause
branch
from
f56e9a8 to
c836750
Compare
The cheri-inefficient diagnostic message only mentioned an underaligned destination, whereas an underaligned source can also trigger it. Fix the diagnostic message by mentioning not only an underaligned destination but also an underaligned source as potential causes.
Flowdalic
force-pushed
the
cheri-inefficient-source-cause
branch
from
c836750 to
40d7a89
Compare
arichardson
approved these changes
Dec 29, 2025
Member
arichardson
left a comment
arichardson
left a comment
There was a problem hiding this comment.
This is a pretty bad warnin, sorry about that! New message is better and helpful until this is fixed properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cheri-inefficient diagnostic message only mentioned an underaligned destination, whereas an underaligned source can also trigger it. Fix the diagnostic message by mentioning not only an underaligned destination but also an underaligned source as potential causes.