Merged: [maglev] Compare tagged values when comparing Smis

LeszekSwirski · LeszekSwirski · commit 12539b8abf4e · 2023-05-23T13:16:40.000Z
Revision: bf6aa50 BUG=v8:7700, chromium:1440723 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=verwaest@chromium.org Change-Id: I8be744aa42858c23f5e38974328419468bebc7e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4556324 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/branch-heads/11.5@{#2} Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1} Cr-Branched-From: b71d303-refs/heads/main@{#87781}
diff --git a/src/maglev/arm64/maglev-assembler-arm64-inl.h b/src/maglev/arm64/maglev-assembler-arm64-inl.h
@@ -765,7 +765,7 @@ inline void MaglevAssembler::CompareSmiAndJumpIf(Register r1, Smi value,
                                                  Condition cond, Label* target,
                                                  Label::Distance distance) {
   AssertSmi(r1);
-  CompareAndBranch(r1, Immediate(value), cond, target);
+  CompareTaggedAndBranch(r1, Immediate(value), cond, target);
 }
 
 inline void MaglevAssembler::TestInt32AndJumpIfAnySet(

Original file line number	Diff line number	Diff line change
`@@ -765,7 +765,7 @@ inline void MaglevAssembler::CompareSmiAndJumpIf(Register r1, Smi value,`
`765`	`765`	`Condition cond, Label* target,`
`766`	`766`	`Label::Distance distance) {`
`767`	`767`	`AssertSmi(r1);`
`768`		`- CompareAndBranch(r1, Immediate(value), cond, target);`
	`768`	`+ CompareTaggedAndBranch(r1, Immediate(value), cond, target);`
`769`	`769`	`}`
`770`	`770`
`771`	`771`	`inline void MaglevAssembler::TestInt32AndJumpIfAnySet(`