Skip to content

Move EditAction Behavior to Indexes #248

@bonham79

Description

@bonham79

With #247, most of the work in instantiating edit actions for the transducer is coming from the Index. It would make more sense to just make this inherited behavior from the Index class and create a new 'ActionIndex` class that takes over all behavior related to edit action creation. This would allow the target_vocabulary related behavior for the transducer to be managed at index creation, instead of adding hacks in the train and model code.

I'm also gonna sneak in potential changes to the expert class that trains the SED when creating the dataloader, allowing us to only iterate through the train set once. With enough code moved around, the expert class can be changed to a mixin (which I'll handle in a separate PR.)

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingenhancementNew feature or request

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions