Update tests, fix unsafe warnings

Author: CVanF5

.vscode/settings.json

@@ -0,0 +1,18 @@
+{
+    "rust-analyzer.cargo.features": [
+        "export-modules",
+        "extproc-mock",
+        "vendored"
+    ],
+    "rust-analyzer.cargo.allFeatures": false,
+    "rust-analyzer.cargo.buildScripts.enable": true,
+    "rust-analyzer.check.command": "check",
+    "rust-analyzer.check.allTargets": true,
+    "rust-analyzer.procMacro.enable": true,
+    "rust-analyzer.diagnostics.disabled": [
+        "inactive-code"
+    ],
+    "rust-analyzer.server.extraEnv": {
+        "NGX_NO_SIGNATURE_CHECK": "1"
+    }
+}

Makefile

@@ -148,6 +148,8 @@ lint:
 	@echo "==> Running Rust linting and formatting checks..."
 	@echo "Checking code formatting..."
 	@cargo fmt --all -- --check || (echo "❌ Code formatting issues found. Run 'cargo fmt --all' to fix." && exit 1)
+	@echo "Running strict compilation check for memory safety errors..."
+	@RUSTFLAGS="-D unsafe-op-in-unsafe-fn -D warnings" cargo check --all-targets --all-features || (echo "❌ Memory safety or compilation errors found." && exit 1)
 	@echo "Running Clippy linter..."
 	@cargo clippy --all-targets --all-features -- -D warnings -A clippy::doc-lazy-continuation -A clippy::enum-variant-names || (echo "❌ Clippy issues found." && exit 1)
 	@echo "Checking for whitespace issues using git..."

build.rs

@@ -4,7 +4,9 @@ fn main() {
 
     // Ensure protoc is available using vendored binary to avoid system dependency.
     let protoc_path = protoc_bin_vendored::protoc_bin_path().expect("vendored protoc not found");
-    std::env::set_var("PROTOC", &protoc_path);
+    unsafe {
+        std::env::set_var("PROTOC", &protoc_path);
+    }
 
     // On macOS, allow unresolved NGINX symbols to be resolved at load time.
     // This enables building the dynamic module outside of the NGINX build system.

src/lib.rs

@@ -53,11 +53,11 @@ impl http::HttpModule for Module {
 
     unsafe extern "C" fn preconfiguration(cf: *mut ngx_conf_t) -> ngx_int_t {
         // Register $inference_upstream variable so it can be used in NGINX config (e.g. proxy_pass http://$inference_upstream;)
-        let cf_ref = &mut *cf;
+        let cf_ref = unsafe { &mut *cf };
         // Allocate variable name from configuration pool
-        let name = &mut ngx_str_t::from_str(cf_ref.pool, "inference_upstream") as *mut _;
+        let name = unsafe { &mut ngx_str_t::from_str(cf_ref.pool, "inference_upstream") as *mut _ };
         // Add variable with no special flags
-        let v = ngx_http_add_variable(cf, name, 0);
+        let v = unsafe { ngx_http_add_variable(cf, name, 0) };
         if v.is_null() {
             return core::Status::NGX_ERROR.into();
         }
@@ -71,17 +71,19 @@ impl http::HttpModule for Module {
 
     unsafe extern "C" fn postconfiguration(cf: *mut ngx_conf_t) -> ngx_int_t {
         // SAFETY: called by NGINX with non-null cf
-        let cf = &mut *cf;
+        let cf = unsafe { &mut *cf };
         let cmcf = NgxHttpCoreModule::main_conf_mut(cf).expect("http core main conf");
 
         // Register an Access phase handler to run before upstream selection.
-        let h = ngx_array_push(
-            &mut cmcf.phases[ngx_http_phases_NGX_HTTP_ACCESS_PHASE as usize].handlers,
-        ) as *mut ngx_http_handler_pt;
+        let h = unsafe {
+            ngx_array_push(
+                &mut cmcf.phases[ngx_http_phases_NGX_HTTP_ACCESS_PHASE as usize].handlers,
+            ) as *mut ngx_http_handler_pt
+        };
         if h.is_null() {
             return core::Status::NGX_ERROR.into();
         }
-        *h = Some(inference_access_handler);
+        unsafe { *h = Some(inference_access_handler) };
         core::Status::NGX_OK.into()
     }
 }