Vendor parse_header out of the deprecated cgi module (#112)

* Vendor parse_header out of the deprecated cgi module

* Migrate to GH Actions

* Update run conditions

* Fix doc build

* Vendor better

* Use a newer Python on RTD

* Bye bye pipelines

* Update rtd config format

* Fix test extras

* Add ftp extra for dist tests

Author: Cadair

.github/workflows/ci_workflows.yml

@@ -0,0 +1,44 @@
+name: CI
+
+on:
+  push:
+    branches:
+      - 'main'
+      - '*.*'
+      - '!*backport*'
+    tags:
+      - 'v*'
+      - '!*dev*'
+      - '!*pre*'
+      - '!*post*'
+  pull_request:
+  # Allow manual runs through the web UI
+  workflow_dispatch:
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+
+  tests:
+    uses: OpenAstronomy/github-actions-workflows/.github/workflows/tox.yml@v1
+    with:
+      envs: |
+        - linux: mypy
+        - linux: py38-conda
+        - linux: py310
+        - linux: py311
+        - linux: py39
+        - windows: py38
+        - macos: py37
+      coverage: 'codecov'
+
+  publish:
+    needs: tests
+    uses: OpenAstronomy/github-actions-workflows/.github/workflows/publish_pure_python.yml@v1
+    with:
+      test_extras: tests,ftp
+      test_command: pytest --pyargs parfive
+    secrets:
+      pypi_token: ${{ secrets.pypi_token }}

.readthedocs.yml

@@ -1,21 +1,24 @@
 # .readthedocs.yml
 # Read the Docs configuration file
 # See https://docs.readthedocs.io/en/stable/config-file/v2.html for details
-
-# Required
 version: 2
 
-# Build documentation in the docs/ directory with Sphinx
+build:
+  os: ubuntu-22.04
+  tools:
+    python: "3.10"
+  apt_packages:
+    - graphviz
+
 sphinx:
   builder: html
   configuration: docs/conf.py
   fail_on_warning: true
 
-# Set the version of Python and requirements required to build your docs
 python:
-  version: 3.8
-  install:
-    - method: pip
-      path: .
-      extra_requirements:
+   install:
+     - method: pip
+       path: .
+       extra_requirements:
         - docs
+        - ftp

azure-pipelines.yml

@@ -1,5 +1,4 @@
 import os
-import cgi
 import asyncio
 import hashlib
 import pathlib
@@ -22,12 +21,45 @@
 ]
 
 
+# Copied out of CPython under PSF Licence 2
+def _parseparam(s):
+    while s[:1] == ";":
+        s = s[1:]
+        end = s.find(";")
+        while end > 0 and (s.count('"', 0, end) - s.count('\\"', 0, end)) % 2:
+            end = s.find(";", end + 1)
+        if end < 0:
+            end = len(s)
+        f = s[:end]
+        yield f.strip()
+        s = s[end:]
+
+
+def parse_header(line):
+    """Parse a Content-type like header.
+    Return the main content-type and a dictionary of options.
+    """
+    parts = _parseparam(";" + line)
+    key = parts.__next__()
+    pdict = {}
+    for p in parts:
+        i = p.find("=")
+        if i >= 0:
+            name = p[:i].strip().lower()
+            value = p[i + 1 :].strip()
+            if len(value) >= 2 and value[0] == value[-1] == '"':
+                value = value[1:-1]
+                value = value.replace("\\\\", "\\").replace('\\"', '"')
+            pdict[name] = value
+    return key, pdict
+
+
 def default_name(path: os.PathLike, resp: aiohttp.ClientResponse, url: str) -> os.PathLike:
     url_filename = url.split("/")[-1]
     if resp:
         cdheader = resp.headers.get("Content-Disposition", None)
         if cdheader:
-            value, params = cgi.parse_header(cdheader)
+            value, params = parse_header(cdheader)
             name = params.get("filename", url_filename)
         else:
             name = url_filename

parfive/utils.py

@@ -38,9 +38,9 @@ tests =
   pytest-cov
   aiofiles
 docs =
-  sphinx
+  # Book theme seems to not like sphinx 5
+  sphinx<5
   sphinx-automodapi
-  sunpy-sphinx-theme
   sphinx-autodoc-typehints
   sphinx-contributors
   sphinx-book-theme