Skip to content

Commit dcdcd71

Browse files
Merge pull request #690 from Cairo-Squad/refactor/remove-empty-and-dummy-files
refactor: remove empty files and redundant code
2 parents 945be4a + cab5dc6 commit dcdcd71

File tree

9 files changed

+3
-41
lines changed

9 files changed

+3
-41
lines changed

domain/src/test/java/com/cairosquad/domain/usecase/search/SearchUseCaseTest.kt

Whitespace-only changes.

repository/src/main/java/com/cairosquad/repository/movie/data_source/remote/dto/CreditResponse.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,4 @@ data class CreditResponse(
1010
val id: Int,
1111
@SerialName("cast")
1212
val cast: List<ArtistRemoteDto?>? = null,
13-
// TODO: Add crew?
1413
)

repository/src/main/java/com/cairosquad/repository/version/VersionRepositoryImpl.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.cairosquad.repository.version
22

3-
import android.content.Context
43
import com.cairosquad.domain.repository.VersionRepository
54
import javax.inject.Inject
65

ui/src/main/java/com/cairosquad/ui/more/BottomSheetItem.kt

Lines changed: 0 additions & 10 deletions
This file was deleted.

viewmodel/src/main/java/com/cairosquad/viewmodel/onboarding/DummyState.kt

Lines changed: 0 additions & 3 deletions
This file was deleted.

viewmodel/src/main/java/com/cairosquad/viewmodel/onboarding/OnboardingViewModel.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,14 @@ import javax.inject.Inject
88
@HiltViewModel
99
class OnboardingViewModel @Inject constructor(
1010
private val onboardingUseCase: OnboardingUseCase
11-
) : BaseViewModel<DummyState, OnboardingEffect>(DummyState()), OnboardingInteractionListener {
11+
) : BaseViewModel<OnboardingViewModel.DummyState, OnboardingEffect>(DummyState()),
12+
OnboardingInteractionListener {
1213
override fun onCompleteOnboarding() {
1314
tryToCall(
1415
block = { onboardingUseCase.setOnboardingStateAsCompleted() },
1516
onSuccess = { sendEffect(OnboardingEffect.NavigateToAuthOrHome) },
1617
onError = { sendEffect(OnboardingEffect.NavigateToAuthOrHome) }
1718
)
1819
}
20+
class DummyState
1921
}

viewmodel/src/main/java/com/cairosquad/viewmodel/util/ListUtil.kt

Lines changed: 0 additions & 16 deletions
This file was deleted.

viewmodel/src/test/java/com/cairosquad/viewmodel/base/BaseViewModelTest.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import kotlinx.coroutines.Dispatchers
77
import kotlinx.coroutines.ExperimentalCoroutinesApi
88
import kotlinx.coroutines.flow.first
99
import kotlinx.coroutines.launch
10-
import kotlinx.coroutines.test.TestScope
1110
import kotlinx.coroutines.test.UnconfinedTestDispatcher
1211
import kotlinx.coroutines.test.advanceUntilIdle
1312
import kotlinx.coroutines.test.resetMain
@@ -23,7 +22,6 @@ import org.junit.Test
2322
class BaseViewModelTest {
2423

2524
private val testDispatcher = UnconfinedTestDispatcher()
26-
private val testScope = TestScope(testDispatcher)
2725

2826
data class TestState(val value: Int = 0, val error: Int = 0)
2927

viewmodel/src/test/java/com/cairosquad/viewmodel/see_all/SeeAllSeriesPagerTest.kt

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)