Flickr Datasource issues with Read function model->uri->query

[jigzstar]

I have found an issue while updating the Flickr plugin to use Copula:

In ApiSource.php->read():
uri->query = is set to be a string a=xxx&b=yyyy

$model->request['uri']['query'] = $this->_buildQuery($conditions);

However in Network->http->httpSocketOath.php

Line 176 block:

        if (isset($request['uri']['query'])) {
$requestParams =array_merge($requestParams,$this->assocToNumericNameValue($request['uri']['query']));
        }

expects uri->query to be an Array since it calls assocToNumericNameValue,

I fixed for my purposes by setting:

$model->request['uri']['query'] = $conditions;

[tenebrousedge]

Interesting. We'll have to take a look at that, I've been wanting to rewrite HttpSocket tbh; or maybe it's time to switch to the new Http layer from Cake 3.0 that @markstory wrote, although I don't entirely like that code. Thanks for the bug report; I'll make sure this gets addressed before the next version.

[markstory]

What don't you like about the new Http Client? I would love to get some feedback on it sooner over later 😄

[tenebrousedge]

Honestly I forget, I'll have to go over it again soon.

On Tue, Sep 10, 2013 at 12:02 PM, Mark Story notifications@github.comwrote:

What don't you like about the new Http Client? I would love to get some
feedback on it sooner over later [image: 😄]

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/25#issuecomment-24189790
.