Skip to content

Commit 5d034b7

Browse files
committed
Feedback fixes.
1 parent 83f4ad2 commit 5d034b7

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

soh/soh/Enhancements/game-interactor/vanilla-behavior/GIVanillaBehavior.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2259,7 +2259,7 @@ typedef enum {
22592259
// CVarGetInteger(CVAR_SETTING("3DSceneRender"), 0)
22602260
// ```
22612261
// #### `args`
2262-
// - `*DoorShutter`
2262+
// - None
22632263
VB_DRAW_2D_BACKGROUND,
22642264
} GIVanillaBehavior;
22652265

soh/soh/SohGui/SohMenuEnhancements.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -560,10 +560,10 @@ void SohMenu::AddMenuEnhancements() {
560560
.RaceDisable(false)
561561
.Options(IntSliderOptions().Min(4).Max(6).DefaultValue(6).Tooltip(
562562
"Space between text characters (useful for HD font textures)."));
563-
AddWidget(path, "Use 3D Pre-Rendered Scenes", WIDGET_CVAR_CHECKBOX)
564-
.CVar(CVAR_SETTING("3DSceneRender"))
563+
AddWidget(path, "Disable 2D Pre-Rendered Scenes", WIDGET_CVAR_CHECKBOX)
564+
.CVar(CVAR_ENHANCEMENT("3DSceneRender"))
565565
.RaceDisable(false)
566-
.Options(CheckboxOptions().Tooltip("Replaces 2D with 3D Pre-rendered backgrounds in Scenes."));
566+
.Options(CheckboxOptions().Tooltip("Disables 2D pre-rendered backgrounds. Enable this when using a mod that implements 3D backdrops for these areas."));
567567

568568
AddWidget(path, "Models & Textures", WIDGET_SEPARATOR_TEXT);
569569
AddWidget(path, "Disable LOD", WIDGET_CVAR_CHECKBOX)

soh/soh/z_scene_otr.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -472,9 +472,10 @@ extern "C" s32 OTRfunc_800973FC(PlayState* play, RoomContext* roomCtx) {
472472
gSegments[3] = VIRTUAL_TO_PHYSICAL(roomCtx->unk_34);
473473

474474
OTRScene_ExecuteCommands(play, (SOH::Scene*)roomCtx->roomToLoad);
475-
if (CVarGetInteger(CVAR_SETTING("3DSceneRender"), 0)) {
475+
if (GameInteractor_Should(VB_DRAW_2D_BACKGROUND, true)) {
476476
play->envCtx.skyboxDisabled = false;
477477
}
478+
478479
Player_SetBootData(play, GET_PLAYER(play));
479480
Actor_SpawnTransitionActors(play, &play->actorCtx);
480481

0 commit comments

Comments
 (0)