Skip to content

Commit 0e3a25d

Browse files
committed
Added new field detX_delta in apply_detX()
1 parent 3b20be5 commit 0e3a25d

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

weightwatcher/weightwatcher.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3063,6 +3063,14 @@ def apply_detX(self, ww_layer, params=None):
30633063

30643064
alpha = ww_layer.alpha
30653065

3066+
# Calculate the value of xmin - detX_val in normalized units.
3067+
detX_delta = None
3068+
if ww_layer.xmin:
3069+
xmin = ww_layer.xmin * np.max(evals)/ww_layer.xmax
3070+
detX_delta = xmin - detX_val
3071+
else:
3072+
xmin = None
3073+
30663074

30673075
if WW_PLOT_DETX in plot:
30683076
name = ww_layer.name
@@ -3077,7 +3085,6 @@ def apply_detX(self, ww_layer, params=None):
30773085
plt.axvline(np.log10(detX_val), color='purple', label=r"detX$=1$")
30783086

30793087
if ww_layer.xmin:
3080-
xmin = ww_layer.xmin * np.max(evals)/ww_layer.xmax
30813088
plt.axvline(np.log10(xmin), color='red', label=r"PL $\lambda_{min}$")
30823089

30833090
plt.legend()
@@ -3094,6 +3101,7 @@ def apply_detX(self, ww_layer, params=None):
30943101

30953102
ww_layer.add_column('detX_val', detX_val)
30963103
ww_layer.add_column('detX_val_unrescaled', detX_val_unrescaled)
3104+
ww_layer.add_column('detX_delta', detX_delta)
30973105

30983106
return ww_layer
30993107

0 commit comments

Comments
 (0)