Skip to content

Commit e6e704e

Browse files
committed
Added new field detX_delta in apply_detX()
1 parent d73b904 commit e6e704e

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

weightwatcher/weightwatcher.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2513,6 +2513,14 @@ def apply_detX(self, ww_layer, params=None):
25132513

25142514
alpha = ww_layer.alpha
25152515

2516+
# Calculate the value of xmin - detX_val in normalized units.
2517+
detX_delta = None
2518+
if ww_layer.xmin:
2519+
xmin = ww_layer.xmin * np.max(evals)/ww_layer.xmax
2520+
detX_delta = xmin - detX_val
2521+
else:
2522+
xmin = None
2523+
25162524

25172525
if WW_PLOT_DETX in plot:
25182526
name = ww_layer.name
@@ -2527,7 +2535,6 @@ def apply_detX(self, ww_layer, params=None):
25272535
plt.axvline(np.log10(detX_val), color='purple', label=r"detX$=1$")
25282536

25292537
if ww_layer.xmin:
2530-
xmin = ww_layer.xmin * np.max(evals)/ww_layer.xmax
25312538
plt.axvline(np.log10(xmin), color='red', label=r"PL $\lambda_{min}$")
25322539

25332540
plt.legend()
@@ -2544,6 +2551,7 @@ def apply_detX(self, ww_layer, params=None):
25442551

25452552
ww_layer.add_column('detX_val', detX_val)
25462553
ww_layer.add_column('detX_val_unrescaled', detX_val_unrescaled)
2554+
ww_layer.add_column('detX_delta', detX_delta)
25472555

25482556
return ww_layer
25492557

0 commit comments

Comments
 (0)