Summary
Implement Distribute revenue-pool remainder deterministically as a production-ready improvement in this repository.
Why this matters
Value-moving code must make authorization, state transitions, arithmetic, and failure atomicity explicit.
Scope
Trace the affected public entry point through persistence, external dependencies, and user/operator-visible output. Implement Distribute revenue-pool remainder deterministically without weakening existing authorization, correctness, compatibility, or CI safeguards.
Priority
High
Acceptance criteria
Validation
The PR must include focused regression coverage for this issue, including:
- Authorization and lifecycle preconditions are checked before value or state mutation.
- Successful execution changes each relevant state exactly once and rolls back atomically on failure.
- Arithmetic, boundaries, identifiers, and batch limits are safe for extreme inputs.
Run the repository’s standard formatting, lint, build, and test commands where applicable, and report unrelated pre-existing failures separately.
Non-goals
- Typo-only, formatting-only, or documentation-only changes.
- Unrelated refactors, dependency upgrades, or broad redesigns.
- Weakening security, authorization, CI, validation, or production safeguards.
- Changing public behavior outside this issue’s scope.
Contributor application
Before implementation, comment with relevant experience, a concise implementation approach, expected files or modules, and an estimate for opening the first PR. Wait for maintainer assignment before coding.
PR requirements
Use a feature branch and include Closes #<issue-number>. The PR must address every acceptance criterion, link each criterion to code and tests, explain security and failure-mode handling, include meaningful regression coverage, preserve compatibility, and report validation results.
Quality review
This is a substantive engineering issue. Review will consider correctness, security, failure handling, test quality, scope discipline, and maintainability.
Summary
Implement Distribute revenue-pool remainder deterministically as a production-ready improvement in this repository.
Why this matters
Value-moving code must make authorization, state transitions, arithmetic, and failure atomicity explicit.
Scope
Trace the affected public entry point through persistence, external dependencies, and user/operator-visible output. Implement Distribute revenue-pool remainder deterministically without weakening existing authorization, correctness, compatibility, or CI safeguards.
Priority
High
Acceptance criteria
Validation
The PR must include focused regression coverage for this issue, including:
Run the repository’s standard formatting, lint, build, and test commands where applicable, and report unrelated pre-existing failures separately.
Non-goals
Contributor application
Before implementation, comment with relevant experience, a concise implementation approach, expected files or modules, and an estimate for opening the first PR. Wait for maintainer assignment before coding.
PR requirements
Use a feature branch and include
Closes #<issue-number>. The PR must address every acceptance criterion, link each criterion to code and tests, explain security and failure-mode handling, include meaningful regression coverage, preserve compatibility, and report validation results.Quality review
This is a substantive engineering issue. Review will consider correctness, security, failure handling, test quality, scope discipline, and maintainability.