Skip to content

Commit 474330d

Browse files
stronger test
1 parent d524945 commit 474330d

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

lifelines/tests/test_estimation.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1500,7 +1500,7 @@ def _log_hazard(self, params, T, Xs):
15001500
cb.fit(rossi, "week", "arrest", regressors={"lambda_": rossi.columns, "rho_": ["_int"]})
15011501
wf.fit(rossi, "week", "arrest")
15021502

1503-
assert_frame_equal(cb.summary.loc["lambda_"], wf.summary.loc["lambda_"], check_less_precise=2)
1503+
assert_frame_equal(cb.summary.loc["lambda_"], wf.summary.loc["lambda_"], check_less_precise=1)
15041504
npt.assert_allclose(cb.log_likelihood_, wf.log_likelihood_)
15051505

15061506
cb.fit_left_censoring(rossi, "week", "arrest", regressors={"lambda_": rossi.columns, "rho_": ["_int"]})
@@ -1561,14 +1561,14 @@ def rossi(self):
15611561

15621562
def test_reparameterization_flips_the_sign(self, rossi):
15631563

1564-
covariates = {"lambda_": rossi.columns, "rho_": ["intercept"], "beta_": ["intercept", "fin"]}
1564+
regressors = {"lambda_": rossi.columns, "rho_": ["intercept"], "beta_": ["intercept", "fin"]}
15651565

15661566
cmA = CureModelA()
15671567
cmB = CureModelB()
15681568
cmC = CureModelC()
15691569

1570-
cmA.fit(rossi, "week", event_col="arrest", regressors=covariates)
1571-
cmB.fit(rossi, "week", event_col="arrest", regressors=covariates)
1570+
cmA.fit(rossi, "week", event_col="arrest", regressors=regressors)
1571+
cmB.fit(rossi, "week", event_col="arrest", regressors=regressors)
15721572
cmC.fit(
15731573
rossi,
15741574
"week",
@@ -1577,7 +1577,7 @@ def test_reparameterization_flips_the_sign(self, rossi):
15771577
)
15781578
assert_frame_equal(cmA.summary.loc["lambda_"], cmB.summary.loc["lambda_"])
15791579
assert_frame_equal(cmA.summary.loc["rho_"], cmB.summary.loc["rho_"])
1580-
assert_frame_equal(cmC.summary.loc["beta_"], cmB.summary.loc["beta_"])
1580+
assert_frame_equal(cmC.summary, cmB.summary)
15811581
assert_series_equal(cmA.params_.loc["beta_"], -cmB.params_.loc["beta_"])
15821582

15831583

0 commit comments

Comments
 (0)