Merge pull request #28 from esalu/master

fix "respond is not a function"

Author: martin-css

README.md

@@ -106,7 +106,7 @@ var CarSchema = new Schema({
   colours	   : [{ 
   					type: Schema.Types.ObjectId, 
   					ref: 'Colour'
-  				  ]}
+  				  }]
 });
 CarSchema.plugin(idvalidator);
 var Car = mongoose.model('Car', CarSchema);

lib/id-validator.js

@@ -63,8 +63,8 @@ IdValidator.prototype.validateSchema = function (
                 validator: function (value, respond) {
                     var conditionsCopy = conditions
                     //A query may not implement an isModified function.
-                    if (!!this.isModified && !this.isModified(path)) {
-                        return respond(true)
+                    if (this && !!this.isModified && !this.isModified(path)) {
+                        return respond ? respond(true) : true
                     }
                     if (!(self instanceof IdValidator) || self.enabled) {
                         if (Object.keys(conditionsCopy).length > 0) {
@@ -81,7 +81,7 @@ IdValidator.prototype.validateSchema = function (
                         return validateFunction(this, connection, refModelName,
                             value, conditionsCopy, respond, allowDuplicates)
                     }
-                    return respond(true)
+                    return respond ? respond(true) : true
                 },
                 isAsync: true,
                 message: message
@@ -105,7 +105,7 @@ function executeQuery (query, conditions, validateValue, respond) {
 function validateId (
     doc, connection, refModelName, value, conditions, respond) {
     if (value == null) {
-        return respond(true)
+        return respond ? respond(true) : true
     }
     var refModel = connection.model(refModelName)
     var query = refModel.countDocuments({_id: value})
@@ -116,7 +116,7 @@ function validateIdArray (
     doc, connection, refModelName, values, conditions, respond,
     allowDuplicates) {
     if (values == null || values.length == 0) {
-        return respond(true)
+        return respond ? respond(true) : true
     }
 
     var checkValues = values

package.json

@@ -1,6 +1,6 @@
 {
     "name": "mongoose-id-validator",
-    "version": "0.5.0",
+    "version": "0.5.1",
     "description": "Mongoose plugin to validate that ObjectID references refer to objects that actually exist in the referenced collection",
     "author": {
         "name": "Martin Campbell",