fix: verify recording sizes through signed GET URLs

Author: richiemcilroy

.github/workflows/docker-build-media-server.yml

@@ -80,6 +80,9 @@ jobs:
           docker run --rm --network none --entrypoint bun "$MEDIA_IMAGE" test \
             src/__tests__/lib/recording-verification.integration.test.ts \
             src/__tests__/lib/job-manager.test.ts
+          docker run --rm --network none --entrypoint bun "$MEDIA_IMAGE" test \
+            src/__tests__/lib/media-size.test.ts \
+            src/__tests__/lib/media-probe.integration.test.ts
           docker run --rm --network none --entrypoint bun "$MEDIA_IMAGE" test \
             src/__tests__/lib/media-transfer.test.ts
           docker run --rm --network none --entrypoint bun "$MEDIA_IMAGE" test \

apps/media-server/Dockerfile

@@ -11,7 +11,8 @@ RUN bun install --frozen-lockfile --production
 
 COPY apps/media-server/src ./src
 
-RUN bun test src/__tests__/lib/recording-verification.integration.test.ts src/__tests__/lib/job-manager.test.ts \
+RUN bun test src/__tests__/lib/media-size.test.ts src/__tests__/lib/media-probe.integration.test.ts \
+	&& bun test src/__tests__/lib/recording-verification.integration.test.ts src/__tests__/lib/job-manager.test.ts \
 	&& bun test src/__tests__/lib/media-transfer.test.ts \
 	&& bun test src/__tests__/routes/recording-verification.test.ts \
 	&& bun test src/__tests__/routes/video.test.ts \

apps/media-server/src/__tests__/lib/media-probe.integration.test.ts

@@ -130,6 +130,7 @@ describe("mediaProbe integration tests", () => {
 
 				expect(metadata.duration).toBeGreaterThan(0);
 				expect(metadata.videoCodec).toBeTruthy();
+				expect(metadata.fileSize).toBe(videoData.length);
 			} finally {
 				await server.stop(true);
 			}

apps/media-server/src/__tests__/lib/media-size.test.ts

@@ -0,0 +1,53 @@
+import { describe, expect, test } from "bun:test";
+import { getSourceSize } from "../../lib/media-common";
+
+describe("remote media size", () => {
+	for (const sample of [
+		{
+			status: 206,
+			headers: { "Content-Range": "bytes 0-0/1024", "Content-Length": "1" },
+			size: 1024,
+		},
+		{ status: 200, headers: { "Content-Length": "1024" }, size: 1024 },
+		{ status: 403, headers: { "Content-Length": "1024" }, size: null },
+		{ status: 206, headers: { "Content-Length": "1" }, size: null },
+		{ status: 206, headers: { "Content-Range": "bytes 1-1/1024" }, size: null },
+		{
+			status: 206,
+			headers: { "Content-Range": "bytes 0-0/9007199254740992" },
+			size: null,
+		},
+		{ status: 200, headers: {}, size: null },
+	]) {
+		test(`validates size response ${JSON.stringify(sample)}`, async () => {
+			const server = Bun.serve({
+				port: 0,
+				fetch(request) {
+					expect(request.method).toBe("GET");
+					expect(request.headers.get("range")).toBe("bytes=0-0");
+					return new Response(
+						sample.size === 1024 && sample.status === 200
+							? new Uint8Array(1024)
+							: null,
+						{
+							status: sample.status,
+							headers: sample.headers,
+						},
+					);
+				},
+			});
+			try {
+				const result = getSourceSize(`${server.url}video.mp4`);
+				if (sample.size === null) {
+					await expect(result).rejects.toThrow(
+						"Media input size is unavailable",
+					);
+				} else {
+					expect(await result).toBe(sample.size);
+				}
+			} finally {
+				await server.stop(true);
+			}
+		});
+	}
+});

apps/media-server/src/lib/media-common.ts

@@ -198,17 +198,29 @@ export function normalizeLocalPath(path: string): string {
 }
 
 export async function getSourceSize(path: string): Promise<number> {
-	try {
-		const url = new URL(path);
-		if (url.protocol === "http:" || url.protocol === "https:") {
-			const response = await mediaFetch(path, {
-				method: "HEAD",
-				signal: AbortSignal.timeout(10_000),
-			});
-			const contentLength = response.headers.get("content-length");
-			return contentLength ? Number.parseInt(contentLength, 10) || 0 : 0;
+	if (/^https?:\/\//.test(path)) {
+		const response = await mediaFetch(path, {
+			headers: { Range: "bytes=0-0" },
+			signal: AbortSignal.timeout(10_000),
+		});
+		try {
+			const length =
+				response.status === 206
+					? response.headers
+							.get("content-range")
+							?.match(/^bytes 0-0\/(\d+)$/)?.[1]
+					: response.status === 200
+						? response.headers.get("content-length")
+						: undefined;
+			const size = Number(length);
+			if (!Number.isSafeInteger(size) || size <= 0) {
+				throw new Error("Media input size is unavailable");
+			}
+			return size;
+		} finally {
+			await response.body?.cancel().catch(() => {});
 		}
-	} catch {}
+	}
 
 	try {
 		return (await stat(normalizeLocalPath(path))).size;