fix: require explicit recording benchmark invocation

Author: richiemcilroy

apps/desktop/scripts/stop-editor-performance.md

@@ -522,7 +522,7 @@ From `apps/desktop-gpui`, build the drivers with `cargo build --example studio-f
 
 `CAP_BENCH_FULL_AUDIO_ONLY=1` skips the range experiment. Without it, the driver exits unsuccessfully if decoded ranges differ from the full-track reference. `CAP_BENCH_STREAM_AUDIO=1` also checks every sequential chunk against that reference. Preserve failed range experiments as failures; the known two-hour timestamp-seeking mismatch must not be mistaken for passing progressive-window coverage. Progressive windows use sequential sample positions instead.
 
-The debug Tauri driver is enabled by `CAP_STOP_EDITOR_BENCHMARK_OUTPUT`, with `CAP_STOP_BENCH_SECONDS`, optional `CAP_STOP_BENCH_MIC`, and optional `CAP_STOP_BENCH_SYSTEM_AUDIO`. Use an isolated app identifier and recordings directory. Its injected editor observer waits for a completed render in the existing frame statistics, a visible editor canvas, and two animation frames. A timeout is a failed benchmark, not a successful editor-open measurement. The initial observer only watched worker messages and missed Tauri's direct-canvas renderer; that incomplete run is excluded.
+The debug Tauri driver requires the explicit arguments `--stop-editor-benchmark --allow-real-recording`, both `CAP_STOP_EDITOR_BENCHMARK_OUTPUT` and `CAP_STOP_BENCH_LOG_DIR`, and a private app identifier beginning `so.cap.desktop.stop-editor-benchmark.` with a nonempty suffix. Output and log paths must be fresh private siblings under an existing canonical directory. `CAP_STOP_BENCH_SECONDS` selects 1–86,400 seconds (default 15); `CAP_STOP_BENCH_MIC` and `CAP_STOP_BENCH_SYSTEM_AUDIO` opt into audio. Environment variables alone cannot activate recording. Keep the private identifier and recordings directory isolated from the user library. Its injected editor observer waits for a completed render in the existing frame statistics, a visible editor canvas, and two animation frames. A timeout is a failed benchmark, not a successful editor-open measurement. The initial observer only watched worker messages and missed Tauri's direct-canvas renderer; that incomplete run is excluded.
 
 Existing GPUI drivers include `CAP_GPUI_AUTO_RECORD=studio:60`, `CAP_GPUI_AUTO_NO_MIC=1`, `CAP_GPUI_AUTO_SYSTEM_AUDIO=1`, `CAP_GPUI_AUTO_EDITOR`, and `CAP_GPUI_AUTO_PLAYBACK`. `CAP_GPUI_AUTO_SEEK` targets a fraction of the visible timeline viewport. The new `CAP_GPUI_AUTO_SEEK_TIME=7194.5` targets seconds into the recording and logs the clamped time passed to the ordinary seek method. Use explicit time for long-recording tail checks. Keep app data and recordings isolated from the user's library.
 

apps/desktop/src-tauri/src/lib.rs

@@ -6525,6 +6525,13 @@ type FilteredRegistry = tracing_subscriber::layer::Layered<
 pub type DynLoggingLayer = Box<dyn tracing_subscriber::Layer<FilteredRegistry> + Send + Sync>;
 type LoggingHandle = tracing_subscriber::reload::Handle<Option<DynLoggingLayer>, FilteredRegistry>;
 
+#[cfg(debug_assertions)]
+pub fn initialize_stop_editor_benchmark(
+    create_log_directory: impl FnOnce(&std::path::Path, &std::path::Path) -> std::io::Result<PathBuf>,
+) -> Result<Option<PathBuf>, String> {
+    stop_editor_benchmark::initialize(create_log_directory)
+}
+
 /// Software recovery exists to break GPU-driver crash loops: a process that died
 /// while wgpu adapter/device initialisation was in flight. Any other unexpected
 /// termination (force-quit, power loss, OS kill, a hung shutdown) says nothing
@@ -7075,6 +7082,8 @@ pub async fn run(recording_logging_handle: LoggingHandle, logs_dir: PathBuf) {
         })
         .setup(move |app| {
             let app = app.handle().clone();
+            #[cfg(debug_assertions)]
+            stop_editor_benchmark::validate_app_identifier(&app.config().identifier)?;
             #[cfg(target_os = "macos")]
             let _startup_open_guard = app
                 .try_state::<StartupOpenGate>()

apps/desktop/src-tauri/src/main.rs

@@ -101,22 +101,15 @@ fn main() {
             .join("logs");
 
         #[cfg(debug_assertions)]
-        let path = match (
-            std::env::var_os("CAP_STOP_EDITOR_BENCHMARK_OUTPUT"),
-            std::env::var_os("CAP_STOP_BENCH_LOG_DIR"),
-        ) {
-            (Some(output), Some(directory)) => match create_benchmark_log_directory(
-                std::path::Path::new(&output),
-                std::path::Path::new(&directory),
-            ) {
-                Ok(directory) => directory,
+        let path =
+            match cap_desktop_lib::initialize_stop_editor_benchmark(create_benchmark_log_directory)
+            {
+                Ok(directory) => directory.unwrap_or(path),
                 Err(error) => {
-                    eprintln!("Invalid private benchmark log directory: {error}");
+                    eprintln!("Invalid Stop benchmark invocation: {error}");
                     std::process::exit(2);
                 }
-            },
-            _ => path,
-        };
+            };
 
         path
     };