fix: keep inspected missing uploads out of legacy recovery

Author: richiemcilroy

apps/web/__tests__/unit/desktop-segments-recovery.test.ts

@@ -17,11 +17,14 @@ vi.mock("@cap/database/schema", () => ({
 		phase: "upload.phase",
 		updatedAt: "upload.updatedAt",
 		startedAt: "upload.startedAt",
+		processingError: "upload.processingError",
 	},
 	videoProcessingJobs: { videoId: "job.videoId" },
 }));
 vi.mock("drizzle-orm", () => ({
 	and: (...args: unknown[]) => args,
+	or: (...args: unknown[]) => ({ or: args }),
+	notLike: (left: unknown, right: unknown) => ({ notLike: [left, right] }),
 	asc: (value: unknown) => value,
 	eq: (left: unknown, right: unknown) => ({ eq: [left, right] }),
 	inArray: (left: unknown, right: unknown) => ({ in: [left, right] }),
@@ -51,6 +54,7 @@ vi.mock("@/lib/desktop-segments-finalization", () => ({
 }));
 vi.mock("@/lib/desktop-recording-jobs", () => ({
 	listRecoverableSegmentJobs: mocks.recoverable,
+	DESKTOP_RECORDING_SOURCE_REUPLOAD_REQUIRED: "source-reupload-required",
 	SourceCommitPendingError: class SourceCommitPendingError extends Error {},
 	DesktopRecordingSourceBlockedError: class DesktopRecordingSourceBlockedError extends Error {
 		constructor(
@@ -234,6 +238,7 @@ describe("durable recovery scheduling", () => {
 		expect(query).toContain('"processing"');
 		expect(query).not.toContain("28 HOUR");
 		expect(query).toContain("startedAt");
+		expect(query).toContain("source-reupload-required:%");
 		expect(mocks.put).not.toHaveBeenCalled();
 	});
 

apps/web/lib/desktop-segments-recovery.ts

@@ -6,9 +6,21 @@ import {
 } from "@cap/database/schema";
 import { Storage } from "@cap/web-backend";
 import { type User, Video } from "@cap/web-domain";
-import { and, asc, eq, gte, inArray, isNull, lte, sql } from "drizzle-orm";
+import {
+	and,
+	asc,
+	eq,
+	gte,
+	inArray,
+	isNull,
+	lte,
+	notLike,
+	or,
+	sql,
+} from "drizzle-orm";
 import { Effect, Option, Schema } from "effect";
 import {
+	DESKTOP_RECORDING_SOURCE_REUPLOAD_REQUIRED,
 	DesktopRecordingSourceBlockedError,
 	listRecoverableSegmentJobs,
 	SourceCommitPendingError,
@@ -251,6 +263,13 @@ export async function recoverStaleDesktopSegments({
 					new Date(now.getTime() - DESKTOP_SEGMENTS_LEGACY_RECOVERY_MAX_AGE_MS),
 				),
 				isNull(videoProcessingJobs.videoId),
+				or(
+					isNull(videoUploads.processingError),
+					notLike(
+						videoUploads.processingError,
+						`${DESKTOP_RECORDING_SOURCE_REUPLOAD_REQUIRED}:%`,
+					),
+				),
 				sql`JSON_UNQUOTE(JSON_EXTRACT(${videos.source}, '$.type')) = 'desktopSegments'`,
 			),
 		)