Skip to content

Commit b577231

Browse files
committed
fix: keep narrow share controls and dark tooltips readable
1 parent b843f92 commit b577231

6 files changed

Lines changed: 51 additions & 4 deletions

File tree

71.6 KB
Loading
61.8 KB
Loading
Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
{
2+
"method": "CUA Chrome Guest, file fixture; exact outer header class from current source, real Tailwind config + local font; placeholders for owner/avatar/content. Not full app validation.",
3+
"before": {
4+
"320": {
5+
"avatarRight": 125,
6+
"helpX": 99.890625,
7+
"overlapPx": 25.109375,
8+
"titleWidth": 0
9+
},
10+
"393": {
11+
"avatarRight": 125,
12+
"helpX": 172.890625,
13+
"overlapPx": 0,
14+
"titleWidth": 23.890625
15+
}
16+
},
17+
"after": {
18+
"320": {
19+
"headerHeight": 99,
20+
"titleWidth": 133.71875,
21+
"avatarY": [15, 47],
22+
"controlsY": [61, 91],
23+
"overlap": false
24+
},
25+
"393": {
26+
"headerHeight": 99,
27+
"titleWidth": 133.71875,
28+
"avatarY": [15, 47],
29+
"controlsY": [61, 91],
30+
"overlap": false
31+
},
32+
"640": {
33+
"headerHeight": 56,
34+
"titleWidth": 133.71875,
35+
"avatarRight": 173.828125,
36+
"controlsX": 419.890625,
37+
"overlap": false
38+
},
39+
"1280": {
40+
"headerHeight": 56,
41+
"titleWidth": 133.71875,
42+
"avatarRight": 221.828125,
43+
"controlsX": 899.796875,
44+
"overlap": false
45+
}
46+
}
47+
}
34.9 KB
Loading

apps/web/app/s/[videoId]/Share.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -802,7 +802,7 @@ export const Share = ({
802802
// border), so the two read as one contained, rounded unit,
803803
// centred at the same width. Classic view's toggle lives under
804804
// the player instead.
805-
<div className="mx-auto flex h-14 w-full max-w-6xl items-center justify-between gap-3 rounded-t-xl border border-b-0 border-gray-5 bg-gray-1 px-5">
805+
<div className="mx-auto flex w-full max-w-6xl flex-col items-stretch gap-2 rounded-t-xl border border-b-0 border-gray-5 bg-gray-1 px-3 py-2 sm:h-14 sm:flex-row sm:items-center sm:justify-between sm:gap-3 sm:px-5 sm:py-0">
806806
<div className="flex min-w-0 items-center gap-3">
807807
<ShareNavigation />
808808
<SignedImageUrl

apps/web/app/s/[videoId]/_components/video/media-player.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3759,15 +3759,15 @@ function MediaPlayerTooltip(props: MediaPlayerTooltipProps) {
37593759
<TooltipContent
37603760
container={context.portalContainer}
37613761
sideOffset={tooltipSideOffset}
3762-
className="flex items-center gap-2 border bg-white px-2 py-1 font-medium text-black data-[side=top]:mb-3.5 [&>span]:hidden"
3762+
className="flex items-center gap-2 border border-gray-6 bg-gray-1 px-2 py-1 font-medium text-gray-12 data-[side=top]:mb-3.5 [&>span]:hidden"
37633763
>
37643764
<p>{tooltip}</p>
37653765
{Array.isArray(shortcut) ? (
37663766
<div className="flex gap-1 items-center">
37673767
{shortcut.map((shortcutKey) => (
37683768
<kbd
37693769
key={shortcutKey}
3770-
className="select-none rounded border bg-white px-1.5 py-0.5 font-mono text-[11.2px] text-black shadow-xs"
3770+
className="select-none rounded border border-gray-6 bg-gray-3 px-1.5 py-0.5 font-mono text-[11.2px] text-gray-12 shadow-xs"
37713771
>
37723772
<abbr title={shortcutKey} className="no-underline">
37733773
{shortcutKey}
@@ -3779,7 +3779,7 @@ function MediaPlayerTooltip(props: MediaPlayerTooltipProps) {
37793779
shortcut && (
37803780
<kbd
37813781
key={shortcut}
3782-
className="select-none rounded border bg-white px-1.5 py-px font-mono text-[11.2px] text-foreground shadow-xs"
3782+
className="select-none rounded border border-gray-6 bg-gray-3 px-1.5 py-px font-mono text-[11.2px] text-gray-12 shadow-xs"
37833783
>
37843784
<abbr title={shortcut} className="no-underline">
37853785
{shortcut}

0 commit comments

Comments
 (0)