[ENG-9544] Fix drag and drop file moves (#787)

* fix(files): Fix drag and drop file moves

* fix(files): Fix duplicate items when shift-clicking files

* chore(files): Remove comment

Author: futa-ikeda

src/app/features/files/components/confirm-move-file-dialog/confirm-move-file-dialog.component.ts

@@ -74,7 +74,7 @@ export class ConfirmMoveFileDialogComponent {
     files.forEach((file) => {
       const link = file.links.move;
       this.filesService
-        .moveFile(link, path, this.fileProjectId, this.provider(), action)
+        .moveFile(link, path, this.fileProjectId, this.provider, action)
         .pipe(
           takeUntilDestroyed(this.destroyRef),
           catchError((error) => {
@@ -116,7 +116,7 @@ export class ConfirmMoveFileDialogComponent {
       acceptLabelKey: 'common.buttons.replace',
       onConfirm: () => {
         const replaceRequests$ = conflictFiles.map(({ link }) =>
-          this.filesService.moveFile(link, path, this.fileProjectId, this.provider(), action, true).pipe(
+          this.filesService.moveFile(link, path, this.fileProjectId, this.provider, action, true).pipe(
             takeUntilDestroyed(this.destroyRef),
             catchError(() => of(null))
           )

src/app/features/files/pages/files/files.component.html

@@ -150,7 +150,7 @@
       (setCurrentFolder)="setCurrentFolder($event)"
       (setMoveDialogCurrentFolder)="setMoveDialogCurrentFolder($event)"
       (updateFoldersStack)="onUpdateFoldersStack($event)"
-      (resetFilesProvider)="resetProvider()"
+      (resetFilesProvider)="resetOnDialogClose()"
     >
     </osf-files-tree>
   </div>

src/app/features/files/pages/files/files.component.ts

@@ -445,7 +445,8 @@ export class FilesComponent {
   }
 
   onFileTreeSelected(file: FileModel): void {
-    this.filesSelection = [...this.filesSelection, file];
+    this.filesSelection.push(file);
+    this.filesSelection = [...new Set(this.filesSelection)];
   }
 
   onFileTreeUnselected(file: FileModel): void {
@@ -542,6 +543,12 @@ export class FilesComponent {
     }
   }
 
+  resetOnDialogClose(): void {
+    this.onClearSelection();
+    this.resetProvider();
+    this.updateFilesList();
+  }
+
   createFolder(): void {
     const currentFolder = this.currentFolder();
     const newFolderLink = currentFolder?.links.newFolder;