Skip to content

Commit 46890bb

Browse files
committed
drop elastic6
1 parent 709ff1d commit 46890bb

23 files changed

Lines changed: 49 additions & 891 deletions

.github/workflows/test_djelme.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,6 @@ jobs:
2828
python: ['3.10', '3.11', '3.12', '3.13', '3.14']
2929
django: ['4.2', '5.1', '5.2']
3030
services:
31-
elasticsearch6:
32-
image: elasticsearch:6.8.23
33-
ports:
34-
- 9206:9200
3531
elasticsearch8:
3632
image: elasticsearch:8.19.11
3733
ports:
@@ -51,9 +47,8 @@ jobs:
5147
run: alias python${{ steps.setup-py.outputs.python-version }}=${{ steps.setup-py.outputs.python-path }}
5248

5349
- name: install despondencies
54-
run: pip install -U poetry && poetry install --with=dev --extras=elastic6 --extras=elastic8
50+
run: pip install -U poetry && poetry install --with=dev --extras=elastic8
5551

5652
- run: TOXENV=`echo 'py${{ matrix.python }}-django${{matrix.django}}' | sed 's/\.//g'` poetry run tox
5753
env:
58-
ELASTICSEARCH6_URL: http://localhost:9206
5954
ELASTICSEARCH8_URL: http://localhost:9208

CONTRIBUTING.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,14 @@ install [poetry](https://python-poetry.org):
3636
pip install poetry
3737
```
3838

39-
install the current project (in editable mode) and dependencies (with the `dev` dependency group and the extras `elastic6`, `elastic8`, `anydjango`):
39+
install the current project (in editable mode) and dependencies (with the `dev` dependency group and the extras `elastic8`, `anydjango`):
4040
```
41-
poetry install --with=dev --extras=elastic6 --extras=elastic8 --extras=anydjango
41+
poetry install --with=dev --extras=elastic8 --extras=anydjango
4242
```
4343

4444
### run tests and checks
4545

46-
these expect elasticsearches to be running and configured in `elasticsearch_metrics/tests/settings.py` (or set environment variables `ELASTICSEARCH6_URL` and `ELASTICSEARCH8_URL`) -- see `using docker-style container tools`, below, for one way to do that
46+
these expect elasticsearch to be running and configured in `elasticsearch_metrics/tests/settings.py` (or set environment variable and `ELASTICSEARCH8_URL`) -- see `using docker-style container tools`, below, for one way to do that
4747

4848
running the python module `elasticsearch_metrics.tests` will run tests and linting checks
4949
-- any code merged to `main` should pass for all supported python and django combinations
@@ -93,9 +93,9 @@ see `testbox.Containerfile` and `docker-compose.yml` for a local setup -- runnin
9393

9494
(note: examples use `pc` aliased to a `docker-compose` equivalent)
9595

96-
start elasticsearches in the background
96+
start elasticsearch in the background
9797
```
98-
pc up -d elasticsearch6 elasticsearch8
98+
pc up -d elasticsearch8
9999
```
100100

101101
run tests and lint

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,13 @@ Django app for storing time-series metrics in Elasticsearch.
77
python importables:
88
- `elasticsearch_metrics`
99
- `elasticsearch_metrics.imps.elastic8` (an implementation with elasticsearch 8)
10-
- `elasticsearch_metrics.imps.elastic6` (an implementation with elasticsearch 6; deprecated)
1110
- ...
1211

1312
## Pre-requisites
1413

1514
* Python >=3.10
1615
* Django 4.2, 5.1, or 5.2
17-
* Elasticsearch 8 (or 6, for deprecated back-compat)
16+
* Elasticsearch 8
1817

1918
## Install
2019

docker-compose.yml

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,11 @@
11
version: '3'
22
services:
3-
elasticsearch6:
4-
image: docker.elastic.co/elasticsearch/elasticsearch:6.3.1
5-
healthcheck:
6-
interval: 30s
7-
retries: 10
8-
test: curl -s http://localhost:9200/_cluster/health | grep -vq '"status":"red"'
9-
networks:
10-
- djelme
113
elasticsearch8:
124
image: docker.elastic.co/elasticsearch/elasticsearch:8.19.11
135
environment:
146
- xpack.security.enabled=false
157
- discovery.type=single-node
8+
- ES_JAVA_OPTS=-Xms256m -Xmx256m # reduce memory usage
169
healthcheck:
1710
interval: 30s
1811
retries: 10
@@ -24,13 +17,10 @@ services:
2417
context: .
2518
dockerfile: testbox.Containerfile
2619
depends_on:
27-
elasticsearch6:
28-
condition: service_healthy
2920
elasticsearch8:
3021
condition: service_healthy
3122
environment:
3223
# TOXENV: py310-django42
33-
ELASTICSEARCH6_URL: elasticsearch6:9200
3424
ELASTICSEARCH8_URL: http://elasticsearch8:9200
3525
networks:
3626
- djelme
Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1 @@
1-
__all__ = (
2-
"elastic6",
3-
"elastic8",
4-
)
1+
__all__ = ("elastic8",)

0 commit comments

Comments
 (0)