remove DJELME_AUTOSETUP

Author: aaxelb

README.md

@@ -61,15 +61,9 @@ class UsageRecord(EventRecord):
         using = "my-es8-backend"  # backend name -- required if multiple backends use the same imp
 ```
 
-Either enable autosetup...
-```python
-# ... in your django project settings file ...
-DJELME_AUTOSETUP = True
-```
-
-...or be sure to run the `djelme_backend_setup` management command before trying to store anything.
+and be sure to run the `djelme_backend_setup` management command before trying to store anything:
 ```shell
-# This will create an index template for usagerecord timeseries indexes
+# This will create an index template for each timeseries record type
 python manage.py djelme_backend_setup
 ```
 
@@ -192,10 +186,6 @@ class UsageRecord(MyBaseMetric):
   }
   ```
 
-* `DJELME_AUTOSETUP`: Optional feature, default `False` --
-    set `True` to run backend setup automatically when your django app starts
-    (like creating index templates in elasticsearch, if they don't already exist)
-
 * `DJELME_DEFAULT_TIMEDEPTH`: Set the granularity of timeseries indexes by the number of "time parts" in index names
     ```
     DJELME_DEFAULT_TIMEDEPTH = 1  # yearly indexes; YYYY

elasticsearch_metrics/apps.py

@@ -1,44 +1,22 @@
 import collections
 
 from django.apps import AppConfig
-from django.conf import settings
-from django.db.models.signals import post_migrate
 from django.utils.module_loading import autodiscover_modules
 
 from elasticsearch_metrics.registry import djelme_registry
 
-AUTOSETUP_SETTING = "DJELME_AUTOSETUP"
-
-
-def do_djelme_setup(*, app_config, stdout, **kwargs):
-    _types_by_backend = djelme_registry.recordtypes_by_backend(
-        app_label=app_config.label
-    )
-    breakpoint()
-    for _backend_name, _recordtypes in _types_by_backend.items():
-        _backend = djelme_registry.get_backend(_backend_name)
-        _backend.djelme_setup(_recordtypes)
-
 
 class ElasticsearchMetricsConfig(AppConfig):
     name = "elasticsearch_metrics"
 
     def ready(self) -> None:
-        # connect django signals
-        if getattr(settings, AUTOSETUP_SETTING, False) is True:
-            post_migrate.connect(do_djelme_setup)
         # discover any `foo.metrics` in installed apps
         autodiscover_modules("metrics")
-        # load backends settings
-        _backend_names_by_module = collections.defaultdict(list)
-        for (
-            _backend_name,
-            _imp_module_name,
-            _,
-        ) in djelme_registry.each_backend_settings():
-            _backend_names_by_module[_imp_module_name].append(_backend_name)
-        # call `djelme_when_ready` once for each imp module
-        for _imp_module_name, _backend_names in _backend_names_by_module.items():
+        # call `djelme_when_ready` once for each djelme imp module used by a backend
+        _backends_by_imp: dict[str, list[str]] = collections.defaultdict(list)
+        for _backend_name, _imp_name, _ in djelme_registry.each_backend_settings():
+            _backends_by_imp[_imp_name].append(_backend_name)
+        for _imp_module_name, _backend_names in _backends_by_imp.items():
             _imp_module = djelme_registry.get_imp_module(_imp_module_name)
             _imp_module.djelme_when_ready(
                 backends=[

elasticsearch_metrics/tests/settings.py

@@ -13,7 +13,6 @@
 MIDDLEWARE_CLASSES = []
 DATABASES = {"default": {"ENGINE": "django.db.backends.sqlite3", "NAME": "test_djelme"}}
 
-DJELME_AUTOSETUP = True
 DJELME_BACKENDS = {
     "my_elastic6": {
         "elasticsearch_metrics.imps.elastic6": {