Skip to content

Commit f2b92e5

Browse files
committed
unofficial ducktype elastic_client
1 parent 4e83367 commit f2b92e5

3 files changed

Lines changed: 7 additions & 6 deletions

File tree

elasticsearch_metrics/imps/elastic6.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ class DjelmeElastic6Backend:
356356
imp_kwargs: dict[str, str]
357357

358358
@property
359-
def elastic6_client(self):
359+
def elastic_client(self):
360360
# assumes `connections.configure` was already called
361361
return connections.get_connection(self.backend_name)
362362

@@ -378,9 +378,10 @@ def djelme_teardown(self, recordtypes: collections.abc.Iterable[type]) -> None:
378378
logger.info("tearing down %r", _metric_type)
379379
_indexname_wildcard = _metric_type._template_pattern
380380
_templatename = _metric_type._template_name
381-
self.elastic6_client.indices.delete(index=_indexname_wildcard)
381+
_client = self.elastic_client
382+
_client.indices.delete(index=_indexname_wildcard)
382383
try:
383-
self.elastic6_client.indices.delete_template(_templatename)
384+
_client.indices.delete_template(_templatename)
384385
except NotFoundError:
385386
pass
386387

elasticsearch_metrics/imps/elastic8.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -775,7 +775,7 @@ def default_index_name_prefix(self) -> str:
775775
return self.imp_kwargs.get("djelme_default_index_name_prefix", "")
776776

777777
@property
778-
def elastic8_client(self) -> Elastic8Client:
778+
def elastic_client(self) -> Elastic8Client:
779779
# assumes `connections.configure` was already called
780780
return esdsl.connections.get_connection(self._elastic8dsl_connection_name)
781781

@@ -802,7 +802,7 @@ def djelme_teardown(self, recordtypes: collections.abc.Iterable[type]) -> None:
802802
# for ProtoDjelmeBackend
803803
for _recordtype in recordtypes:
804804
assert issubclass(_recordtype, BaseDjelmeRecord)
805-
_recordtype.do_teardown(self.elastic8_client)
805+
_recordtype.do_teardown(self.elastic_client)
806806

807807

808808
if __debug__ and typing.TYPE_CHECKING:

elasticsearch_metrics/tests/test_imps_elastic8.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def _es8_client(
3434
) -> elasticsearch8.Elasticsearch:
3535
_backend = djelme_registry.get_backend(backend_name)
3636
assert isinstance(_backend, djelme.DjelmeElastic8Backend)
37-
return _backend.elastic8_client
37+
return _backend.elastic_client
3838

3939

4040
class TestNamesAndPatterns(SimpleDjelmeTestCase):

0 commit comments

Comments
 (0)