Merge pull request #618 from adlius/Emb-610_Add_campaign_query_param_for_registries

[EMB-610] Add query parameter.

Author: jamescdavis

lib/osf-components/addon/components/osf-navbar/auth-dropdown/component.ts

@@ -19,7 +19,7 @@ import pathJoin from 'ember-osf-web/utils/path-join';
 import styles from './styles';
 import template from './template';
 
-const { OSF: { url: baseUrl }, featureFlagNames } = config;
+const { OSF: { url: baseUrl } } = config;
 
 export class AuthBase extends Component {
     @service analytics!: Analytics;
@@ -53,12 +53,6 @@ export class AuthBase extends Component {
         return pathJoin(baseUrl, this.router.currentURL);
     }
 
-    @computed('signUpURL', 'signUpNext')
-    get signUpRoute() {
-        return this.features.isEnabled(featureFlagNames.routes.register) ? 'register' :
-            `${this.signUpURL}?${param(this.signUpQueryParams)}`;
-    }
-
     @computed('router.currentRouteName', 'signUpNext')
     get signUpQueryParams() {
         const params: Record<string, string> = {};

lib/osf-components/addon/components/osf-navbar/auth-dropdown/template.hbs

@@ -5,7 +5,7 @@
                 data-test-ad-sign-up-button
                 data-analytics-name='SignUp'
                 class='btn btn-success btn-top-signup m-l-sm m-r-xs'
-                @href={{this.signUpRoute}}
+                @route='register'
                 @queryParams={{this.signUpQueryParams}}
             >
                 {{t 'auth_dropdown.sign_up'}}

tests/engines/registries/integration/components/registries-navbar/component-test.ts

@@ -1,6 +1,5 @@
 import Service from '@ember/service';
 import { click, fillIn, render, triggerKeyEvent } from '@ember/test-helpers';
-import config from 'ember-get-config';
 import { t } from 'ember-i18n/test-support';
 import { setupEngineRenderingTest } from 'ember-osf-web/tests/helpers/engines';
 import { setBreakpoint } from 'ember-responsive/test-support';
@@ -10,8 +9,6 @@ import $ from 'jquery';
 import { module, test } from 'qunit';
 import sinon from 'sinon';
 
-const { OSF: { url: osfUrl } } = config;
-
 const statusMessagesStub = Service.extend({
     messages: [],
 
@@ -88,17 +85,12 @@ module('Registries | Integration | Component | registries-navbar', hooks => {
     });
 
     test('desktop layout (logged out)', async function(assert) {
-        const osfUrlEncoded = encodeURIComponent(osfUrl);
         setBreakpoint('desktop');
         this.owner.lookup('service:session').set('isAuthenticated', false);
 
         await render(hbs`<RegistriesNavbar @campaign="osf-registries" @signUpURL="http://example.com" />`);
 
         assert.dom('a[data-test-join]').hasText(`${t('navbar.join')}`);
-        assert.dom('a[data-test-join]').hasAttribute(
-            'href',
-            `http://example.com?campaign=osf-registries&next=${osfUrlEncoded}FakeURL`,
-        );
         assert.dom('a[data-test-join]').isVisible('Join button is visible');
 
         assert.dom('a[role="button"][data-test-login]').hasText(`${t('navbar.login')}`);