Skip to content

Commit ccac917

Browse files
committed
Fix tests
1 parent 7ef26aa commit ccac917

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

addon_service/tests/test_by_type/test_configured_link_addon.py

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def test_get(self):
7575
_resp = self.client.get(self._detail_path)
7676
self.assertEqual(_resp.status_code, HTTPStatus.OK)
7777
self.assertEqual(_resp.data["target_id"], self._addon.target_id)
78-
self.assertEqual(_resp.data["resource_type"], self._addon.resource_type)
78+
self.assertEqual(_resp.data["resource_type"], self._addon.resource_type.name)
7979

8080
def test_methods_not_allowed(self):
8181
_methods_not_allowed = {
@@ -115,13 +115,15 @@ def test_resource_type_property(self):
115115
self._addon.save()
116116

117117
refreshed = db.ConfiguredLinkAddon.objects.get(id=self._addon.id)
118-
self.assertEqual(refreshed.resource_type, "Book")
118+
self.assertEqual(refreshed.resource_type, SupportedResourceTypes.Book)
119+
self.assertEqual(refreshed.resource_type.name, "Book")
119120

120121
self._addon.resource_type = SupportedResourceTypes.Other
121122
self._addon.save()
122123

123124
refreshed = db.ConfiguredLinkAddon.objects.get(id=self._addon.id)
124-
self.assertEqual(refreshed.resource_type, "Other")
125+
self.assertEqual(refreshed.resource_type, SupportedResourceTypes.Other)
126+
self.assertEqual(refreshed.resource_type.name, "Other")
125127

126128
def test_validator_valid_types(self):
127129
try:
@@ -202,7 +204,9 @@ def test_get(self):
202204

203205
with self.subTest("Confirm expected attributes"):
204206
self.assertEqual(_resp.data["target_id"], self._addon.target_id)
205-
self.assertEqual(_resp.data["resource_type"], self._addon.resource_type)
207+
self.assertEqual(
208+
_resp.data["resource_type"], self._addon.resource_type.name
209+
)
206210
self.assertIn("connected_operation_names", _resp.data)
207211

208212
with self.subTest("Confirm expected relationships"):
@@ -286,7 +290,7 @@ def test_create_addon(self):
286290
"type": "configured-link-addons",
287291
"attributes": {
288292
"target_id": "some-target-id",
289-
"resource_type": "DATASET",
293+
"resource_type": "Other",
290294
"connected_capabilities": ["ACCESS"],
291295
"authorized_resource_uri": self._resource.resource_uri,
292296
},
@@ -315,8 +319,9 @@ def test_create_addon(self):
315319

316320
self.assertEqual(_resp.status_code, HTTPStatus.CREATED)
317321

318-
self.assertEqual(_resp.data["resource_type"], "Other")
322+
self.assertEqual(_resp.data["resource_type"], SupportedResourceTypes.Other.name)
319323

320324
addon = db.ConfiguredLinkAddon.objects.get(id=_resp.data["id"])
321325
self.assertEqual(addon.target_id, "some-target-id")
322-
self.assertEqual(addon.resource_type, "Other")
326+
self.assertEqual(addon.resource_type, SupportedResourceTypes.Other)
327+
self.assertEqual(addon.resource_type.name, "Other")

0 commit comments

Comments
 (0)