[ENG-9060] Osf admin can recreate preprint version 1 with unregistered contributors (#11362)

* osf admin can recreate preprint version 1 with unregistered contributors

* fix test (#11394)

* fix test

* fix other serializers

* linting

* osf admin can recreate preprint version 1 with unregistered contributors

---------

Co-authored-by: Yuhuai Liu <[email protected]>

Author: ihorsokhanexoft

admin_tests/preprints/test_views.py

@@ -22,6 +22,7 @@
 from osf.models.spam import SpamStatus
 from osf.utils.workflows import DefaultStates, RequestTypes
 from osf.utils.permissions import ADMIN
+from framework.auth import Auth
 
 from admin_tests.utilities import setup_view, setup_log_view, handle_post_view_request
 
@@ -834,3 +835,42 @@ def test_admin_user_can_add_new_version_one(self, user, preprint, plain_view):
         preprint.refresh_from_db()
 
         assert len(preprint.get_preprint_versions()) == 2
+
+    def test_osf_admin_can_create_new_version_with_unregistered_contributors(self, plain_view):
+        # user isn't admin contributor in the preprint
+        osf_admin = AuthUserFactory()
+        admin_group = Group.objects.get(name='osf_admin')
+        admin_group.permissions.add(Permission.objects.get(codename='change_node'))
+        osf_admin.groups.add(admin_group)
+
+        user = AuthUserFactory()
+        preprint_admin = AuthUserFactory()
+        preprint = PreprintFactory(creator=user)
+
+        preprint.add_permission(
+            preprint_admin,
+            ADMIN,
+            save=True
+        )
+
+        # assume admin contributor added an unregistered contributor
+        preprint.add_unregistered_contributor(
+            'Rheisen Dennis',
+            '[email protected]',
+            auth=Auth(preprint_admin),
+            save=True
+        )
+
+        # osf admin recreates a new version 1 that forces to add unregistered contributors
+        # to this preprint
+        request = RequestFactory().post(
+            reverse('preprints:re-version-preprint',
+            kwargs={'guid': preprint._id}),
+            data={'file_versions': ['1']}
+        )
+        request.user = osf_admin
+
+        plain_view.as_view()(request, guid=preprint._id)
+        preprint.refresh_from_db()
+
+        assert len(preprint.get_preprint_versions()) == 2

osf/models/preprint.py

@@ -532,6 +532,7 @@ def create_version(cls, create_from_guid, auth, assign_version_number=None, igno
                     referrer=auth.user,
                     email=contributor.user.email,
                     given_name=contributor.user.fullname,
+                    skip_referrer_permissions=auth.user.groups.filter(name='osf_admin').exists()
                 )
             except ValidationError as e:
                 sentry.log_exception(e)