Skip to content

selectedItemTextFontFamily and itemTextFontFamily props should be optional #183

@balsick

Description

@balsick

Hi! 👋

Today I used patch-package to patch [email protected] for the project I'm working on.

While most props are set as optional, selectedItemTextFontFamily and itemTextFontFamily don't, but considering the README and the normal usage of the component, they should be set optional as well.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-wheel-picker-android/index.d.ts b/node_modules/react-native-wheel-picker-android/index.d.ts
index 70a48e9..6daabe3 100644
--- a/node_modules/react-native-wheel-picker-android/index.d.ts
+++ b/node_modules/react-native-wheel-picker-android/index.d.ts
@@ -4,10 +4,10 @@ import { DatePickerIOSProps, StyleProp, ViewStyle } from 'react-native';
 interface IStyle {
 	selectedItemTextColor?: string;
 	selectedItemTextSize?: number;
-	selectedItemTextFontFamily: string;
+	selectedItemTextFontFamily?: string;
 	itemTextColor?: string;
 	itemTextSize?: number;
-	itemTextFontFamily: string;
+	itemTextFontFamily?: string;
 	indicatorColor?: string;
 	hideIndicator?: boolean;
 	indicatorWidth?: number;

This issue body was partially generated by patch-package.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions