Added support in the glTF codegen to force optional props as required

Author: weegeekps

CesiumGltfWriter/generated/src/ModelJsonWriter.cpp

@@ -1198,17 +1198,11 @@ void writeJson(
   jsonWriter.Key("colorSpace");
   writeJson(obj.colorSpace, jsonWriter, context);
 
-  if (obj.projection !=
-      CesiumGltf::ExtensionKhrGaussianSplatting::Projection::perspective) {
-    jsonWriter.Key("projection");
-    writeJson(obj.projection, jsonWriter, context);
-  }
+  jsonWriter.Key("projection");
+  writeJson(obj.projection, jsonWriter, context);
 
-  if (obj.sortingMethod != CesiumGltf::ExtensionKhrGaussianSplatting::
-                               SortingMethod::cameraDistance) {
-    jsonWriter.Key("sortingMethod");
-    writeJson(obj.sortingMethod, jsonWriter, context);
-  }
+  jsonWriter.Key("sortingMethod");
+  writeJson(obj.sortingMethod, jsonWriter, context);
 
   writeExtensibleObject(obj, jsonWriter, context);
 

tools/generate-classes/generate.js

@@ -48,6 +48,28 @@ function generate(options, schema, writers) {
 
   const required = schema.required || [];
 
+  // Allows us to force specific optional props as required to meet occasional extension recommendations.
+  const requireOptionalProps = thisConfig.requireOptionalProps;
+  console.log(requireOptionalProps);
+  console.log(schema.properties);
+  if (Array.isArray(requireOptionalProps) && requireOptionalProps.length > 0) {
+    const validProps = Object.keys(schema.properties || {});
+    for (const prop of requireOptionalProps) {
+      if (!validProps.includes(prop)) {
+        // Skip invalid properties.
+        continue;
+      }
+
+      if (required.includes(prop)) {
+        // Don't add props to list if they're already in `required`.
+        continue;
+      }
+
+      required.push(prop);
+    }
+  }
+  console.log(required);
+
   const properties = Object.keys(schema.properties || {})
     .map((key) =>
       resolveProperty(

tools/generate-classes/glTF.json

@@ -165,7 +165,11 @@
       "overrideName": "ExtensionExtPrimitiveVoxels"
     },
     "KHR_gaussian_splatting glTF Mesh Primitive Extension": {
-      "overrideName": "ExtensionKhrGaussianSplatting"
+      "overrideName": "ExtensionKhrGaussianSplatting",
+      "requireOptionalProps": [
+        "projection",
+        "sortingMethod"
+      ]
     },
     "KHR_gaussian_splatting_compression_spz_2 glTF Mesh Primitive Extension": {
       "overrideName": "ExtensionKhrGaussianSplattingCompressionSpz2"