Skip to content

Cesium sets global material parameters unnecessarily #814

Open
@kring

Description

@kring

Before we used material layers for our materials, CesiumGltfComponent.cpp set a bunch of global parameter values from the glTF. When we switched to material layers, we kept doing this for backward compatibility with old materials, and have continued doing so until today. It'd be nice to stop doing this, either by 1) declaring it's been long enough and we don't support those old materials anymore, or by 2) detecting when we need to do so. Unfortunately it's not possible to iterate over material parameters (or at best it's only possible in the Editor), which is why we haven't done (2). And (1) is problematic because there's no warning for users still using old-style materials, mostly because showing a warning would again require us to be able to list the parameter names. The answer might be to do both (1) and (2), but only in the Editor.

Metadata

Metadata

Assignees

No one assigned

    Labels

    performanceImprovements to performance, including reductions in memory usagequalityImprove code quality or encourage developer success

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions