Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Commit 0bc1f20

Browse files
authored
fix: fix message id to be more unique and update logs traceid attribute name (#347)
* fix: make msg.id to be unique and now include source-destination-nonce * fix: change trace_id logs attr to dd.trace_id for DataDog parsing
1 parent 1a13e1b commit 0bc1f20

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

chains/evm/calls/events/listener.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ func (l *Listener) FetchDeposits(ctx context.Context, contractAddress common.Add
3737
ctxWithSpan, span := otel.Tracer("relayer-core").Start(ctx, "relayer.core.Listener.FetchDeposits")
3838
defer span.End()
3939
span.SetAttributes(attribute.String("startBlock", startBlock.String()), attribute.String("endBlock", endBlock.String()))
40-
logger := log.With().Str("trace_id", span.SpanContext().TraceID().String()).Logger()
40+
logger := log.With().Str("dd.trace_id", span.SpanContext().TraceID().String()).Logger()
4141

4242
logs, err := l.client.FetchEventLogs(ctxWithSpan, contractAddress, string(DepositSig), startBlock, endBlock)
4343
if err != nil {

chains/evm/listener/event-handler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ func (eh *DepositEventHandler) HandleEvent(ctx context.Context, startBlock *big.
4646
ctxWithSpan, span := otel.Tracer("relayer-core").Start(ctx, "relayer.core.DepositEventHandler.HandleEvent")
4747
defer span.End()
4848
span.SetAttributes(attribute.String("startBlock", startBlock.String()), attribute.String("endBlock", endBlock.String()))
49-
logger := log.With().Str("trace_id", span.SpanContext().TraceID().String()).Logger()
49+
logger := log.With().Str("dd.trace_id", span.SpanContext().TraceID().String()).Logger()
5050
deposits, err := eh.eventListener.FetchDeposits(ctxWithSpan, eh.bridgeAddress, startBlock, endBlock)
5151
if err != nil {
5252
span.SetStatus(codes.Error, err.Error())

chains/evm/listener/listener.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ func (l *EVMListener) ListenToEvents(ctx context.Context, startBlock *big.Int, m
7878
return
7979
default:
8080
ctxWithSpan, span := otel.Tracer("relayer-core").Start(ctx, "relayer.core.EVMListener.ListenToEvents")
81-
logger := l.log.With().Str("trace_id", span.SpanContext().TraceID().String()).Logger()
81+
logger := l.log.With().Str("dd.trace_id", span.SpanContext().TraceID().String()).Logger()
8282
head, err := l.client.LatestBlock()
8383
if err != nil {
8484
logger.Error().Err(err).Msg("Unable to get latest block")

relayer/message/message.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,5 +94,5 @@ func NewMessage(
9494
}
9595

9696
func (m Message) ID() string {
97-
return strconv.FormatInt(int64(m.Source), 10) + "-" + strconv.FormatInt(int64(m.DepositNonce), 10)
97+
return strconv.FormatInt(int64(m.Source), 10) + "-" + strconv.FormatInt(int64(m.Destination), 10) + "-" + strconv.FormatInt(int64(m.DepositNonce), 10)
9898
}

0 commit comments

Comments
 (0)