Skip to content

Commit 101befd

Browse files
LesnyRumcajsLesnyRumcajs
authored
chore: add actionlint (#6909)
1 parent b0c607b commit 101befd

27 files changed

+114
-766
lines changed

‎.github/actionlint.yaml‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
# Configuration for actionlint (https://github.com/rhysd/actionlint).
3+
# Run locally via: `mise run lint:actions`.
4+
5+
self-hosted-runner:
6+
# WarpBuild self-hosted runners used by performance-sensitive jobs.
7+
labels:
8+
- warp-ubuntu-2404-arm64-8x
9+
- warp-ubuntu-2404-x64-8x

‎.github/workflows/actions-lint.yml‎

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
name: GitHub Actions lint
2+
permissions:
3+
contents: read
4+
5+
# Cancel workflow if there is a new change to the branch.
6+
concurrency:
7+
group: ${{ github.workflow }}-${{ github.ref }}
8+
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
9+
10+
on:
11+
merge_group:
12+
pull_request:
13+
branches:
14+
- main
15+
paths:
16+
- ".github/workflows/**"
17+
- ".github/actionlint.yaml"
18+
- "mise.toml"
19+
push:
20+
branches:
21+
- main
22+
paths:
23+
- ".github/workflows/**"
24+
- ".github/actionlint.yaml"
25+
- "mise.toml"
26+
27+
jobs:
28+
actions-lint:
29+
runs-on: ubuntu-slim
30+
steps:
31+
- uses: actions/checkout@v6
32+
- uses: jdx/mise-action@v4
33+
- run: mise run lint:actions

‎.github/workflows/cargo-advisories.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ jobs:
1818
if: failure()
1919
run: |
2020
export WORKFLOW_URL="${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}"
21-
echo ${WORKFLOW_URL}
22-
echo "WORKFLOW_URL=${WORKFLOW_URL}" >> $GITHUB_ENV
21+
echo "${WORKFLOW_URL}"
22+
echo "WORKFLOW_URL=${WORKFLOW_URL}" >> "$GITHUB_ENV"
2323
- uses: JasonEtco/create-an-issue@v2
2424
if: failure()
2525
env:

‎.github/workflows/cargo-publish-dry-run.yml‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,11 @@ jobs:
2626
run: |
2727
# External PRs do not have access to 'vars' or 'secrets'.
2828
if [[ "${{secrets.AWS_ACCESS_KEY_ID}}" != "" ]]; then
29-
echo "SCCACHE_ENDPOINT=${{ vars.SCCACHE_ENDPOINT}}" >> $GITHUB_ENV
30-
echo "SCCACHE_BUCKET=${{ vars.SCCACHE_BUCKET}}" >> $GITHUB_ENV
31-
echo "SCCACHE_REGION=${{ vars.SCCACHE_REGION}}" >> $GITHUB_ENV
29+
{
30+
echo "SCCACHE_ENDPOINT=${{ vars.SCCACHE_ENDPOINT}}"
31+
echo "SCCACHE_BUCKET=${{ vars.SCCACHE_BUCKET}}"
32+
echo "SCCACHE_REGION=${{ vars.SCCACHE_REGION}}"
33+
} >> "$GITHUB_ENV"
3234
fi
3335
- name: Checkout Sources
3436
uses: actions/checkout@v6
@@ -42,8 +44,8 @@ jobs:
4244
if: failure()
4345
run: |
4446
export WORKFLOW_URL="${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}"
45-
echo ${WORKFLOW_URL}
46-
echo "WORKFLOW_URL=${WORKFLOW_URL}" >> $GITHUB_ENV
47+
echo "${WORKFLOW_URL}"
48+
echo "WORKFLOW_URL=${WORKFLOW_URL}" >> "$GITHUB_ENV"
4749
- uses: JasonEtco/create-an-issue@v2
4850
if: failure()
4951
env:

‎.github/workflows/checkpoints.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
- uses: actions/checkout@v6
1616
- name: Update checkpoints
1717
run: |
18-
docker run --rm -v $PWD:/app -w /app --entrypoint forest-dev ghcr.io/chainsafe/forest:edge update-checkpoints
18+
docker run --rm -v "$PWD":/app -w /app --entrypoint forest-dev ghcr.io/chainsafe/forest:edge update-checkpoints
1919
# This is needed in order to have the commits signed.
2020
- uses: actions/create-github-app-token@v3
2121
id: generate-token

‎.github/workflows/coverage.yml‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,11 @@ jobs:
7171
run: |
7272
# External PRs do not have access to 'vars' or 'secrets'.
7373
if [[ "${{secrets.AWS_ACCESS_KEY_ID}}" != "" ]]; then
74-
echo "SCCACHE_ENDPOINT=${{ vars.SCCACHE_ENDPOINT}}" >> $GITHUB_ENV
75-
echo "SCCACHE_BUCKET=${{ vars.SCCACHE_BUCKET}}" >> $GITHUB_ENV
76-
echo "SCCACHE_REGION=${{ vars.SCCACHE_REGION}}" >> $GITHUB_ENV
74+
{
75+
echo "SCCACHE_ENDPOINT=${{ vars.SCCACHE_ENDPOINT}}"
76+
echo "SCCACHE_BUCKET=${{ vars.SCCACHE_BUCKET}}"
77+
echo "SCCACHE_REGION=${{ vars.SCCACHE_REGION}}"
78+
} >> "$GITHUB_ENV"
7779
fi
7880
- name: Setup sccache
7981
uses: mozilla-actions/sccache-action@v0.0.9
@@ -96,8 +98,8 @@ jobs:
9698
- name: Fetch proof params and RPC test snapshots
9799
run: |
98100
# Use the same profile to re-use some compilation artifacts and speed up the entire job.
99-
cargo llvm-cov run --profile codecov --no-report --bin forest-dev --no-default-features -- fetch-test-snapshots --actor-bundle $FOREST_ACTOR_BUNDLE_PATH
100-
ls -ahl $FIL_PROOFS_PARAMETER_CACHE
101+
cargo llvm-cov run --profile codecov --no-report --bin forest-dev --no-default-features -- fetch-test-snapshots --actor-bundle "$FOREST_ACTOR_BUNDLE_PATH"
102+
ls -ahl "$FIL_PROOFS_PARAMETER_CACHE"
101103
- name: Generate code coverage
102104
run: mise codecov
103105
env:

‎.github/workflows/curio-devnet-publish.yml‎

Lines changed: 0 additions & 60 deletions
This file was deleted.

‎.github/workflows/docker.yml‎

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,11 @@ jobs:
4949
run: |
5050
# External PRs do not have access to 'vars' or 'secrets'.
5151
if [[ "${{secrets.AWS_ACCESS_KEY_ID}}" != "" ]]; then
52-
echo "SCCACHE_ENDPOINT=${{ vars.SCCACHE_ENDPOINT}}" >> $GITHUB_ENV
53-
echo "SCCACHE_BUCKET=${{ vars.SCCACHE_BUCKET}}" >> $GITHUB_ENV
54-
echo "SCCACHE_REGION=${{ vars.SCCACHE_REGION}}" >> $GITHUB_ENV
52+
{
53+
echo "SCCACHE_ENDPOINT=${{ vars.SCCACHE_ENDPOINT}}"
54+
echo "SCCACHE_BUCKET=${{ vars.SCCACHE_BUCKET}}"
55+
echo "SCCACHE_REGION=${{ vars.SCCACHE_REGION}}"
56+
} >> "$GITHUB_ENV"
5557
fi
5658
- name: Checkout Sources
5759
uses: actions/checkout@v6
@@ -84,11 +86,13 @@ jobs:
8486
run: |
8587
# External PRs do not have access to 'vars' or 'secrets'.
8688
if [[ "${{secrets.AWS_ACCESS_KEY_ID}}" != "" ]]; then
87-
echo "SCCACHE_ENDPOINT=${{ vars.SCCACHE_ENDPOINT}}" >> $GITHUB_ENV
88-
echo "SCCACHE_BUCKET=${{ vars.SCCACHE_BUCKET}}" >> $GITHUB_ENV
89-
echo "SCCACHE_REGION=${{ vars.SCCACHE_REGION}}" >> $GITHUB_ENV
89+
{
90+
echo "SCCACHE_ENDPOINT=${{ vars.SCCACHE_ENDPOINT}}"
91+
echo "SCCACHE_BUCKET=${{ vars.SCCACHE_BUCKET}}"
92+
echo "SCCACHE_REGION=${{ vars.SCCACHE_REGION}}"
93+
} >> "$GITHUB_ENV"
9094
fi
91-
echo "SCCACHE_S3_KEY_PREFIX=aarch64" >> $GITHUB_ENV
95+
echo "SCCACHE_S3_KEY_PREFIX=aarch64" >> "$GITHUB_ENV"
9296
- name: Checkout Sources
9397
uses: actions/checkout@v6
9498
if: github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/v')

‎.github/workflows/dockerfile-check.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ jobs:
2222
if: always()
2323
run: |
2424
export WORKFLOW_URL="${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}"
25-
echo ${WORKFLOW_URL}
26-
echo "WORKFLOW_URL=${WORKFLOW_URL}" >> $GITHUB_ENV
25+
echo "${WORKFLOW_URL}"
26+
echo "WORKFLOW_URL=${WORKFLOW_URL}" >> "$GITHUB_ENV"
2727
- uses: JasonEtco/create-an-issue@v2
2828
if: failure()
2929
env:

‎.github/workflows/forest.yml‎

Lines changed: 18 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,13 @@ jobs:
4848
run: |
4949
# External PRs do not have access to 'vars' or 'secrets'.
5050
if [[ "$AWS_ACCESS_KEY_ID" != "" ]]; then
51-
echo "SCCACHE_ENDPOINT=${{ vars.SCCACHE_ENDPOINT}}" >> $GITHUB_ENV
52-
echo "SCCACHE_BUCKET=${{ vars.SCCACHE_BUCKET}}" >> $GITHUB_ENV
53-
echo "SCCACHE_REGION=${{ vars.SCCACHE_REGION}}" >> $GITHUB_ENV
51+
{
52+
echo "SCCACHE_ENDPOINT=${{ vars.SCCACHE_ENDPOINT}}"
53+
echo "SCCACHE_BUCKET=${{ vars.SCCACHE_BUCKET}}"
54+
echo "SCCACHE_REGION=${{ vars.SCCACHE_REGION}}"
55+
} >> "$GITHUB_ENV"
5456
fi
55-
echo "SCCACHE_S3_KEY_PREFIX=macos" >> $GITHUB_ENV
57+
echo "SCCACHE_S3_KEY_PREFIX=macos" >> "$GITHUB_ENV"
5658
- name: Checkout Sources
5759
uses: actions/checkout@v6
5860
- name: Setup sccache
@@ -75,9 +77,11 @@ jobs:
7577
run: |
7678
# External PRs do not have access to 'vars' or 'secrets'.
7779
if [[ "${{secrets.AWS_ACCESS_KEY_ID}}" != "" ]]; then
78-
echo "SCCACHE_ENDPOINT=${{ vars.SCCACHE_ENDPOINT}}" >> $GITHUB_ENV
79-
echo "SCCACHE_BUCKET=${{ vars.SCCACHE_BUCKET}}" >> $GITHUB_ENV
80-
echo "SCCACHE_REGION=${{ vars.SCCACHE_REGION}}" >> $GITHUB_ENV
80+
{
81+
echo "SCCACHE_ENDPOINT=${{ vars.SCCACHE_ENDPOINT}}"
82+
echo "SCCACHE_BUCKET=${{ vars.SCCACHE_BUCKET}}"
83+
echo "SCCACHE_REGION=${{ vars.SCCACHE_REGION}}"
84+
} >> "$GITHUB_ENV"
8185
fi
8286
- name: Checkout Sources
8387
uses: actions/checkout@v6
@@ -473,8 +477,8 @@ jobs:
473477
docker volume create devnet_filecoin-proofs
474478
docker run --rm \
475479
-v devnet_filecoin-proofs:/proofs \
476-
-v $FIL_PROOFS_PARAMETER_CACHE:/cache \
477-
$SHELL_IMAGE \
480+
-v "$FIL_PROOFS_PARAMETER_CACHE":/cache \
481+
"$SHELL_IMAGE" \
478482
sh -c "cp /cache/* /proofs"
479483
- uses: actions/checkout@v6
480484
- uses: actions/download-artifact@v8
@@ -494,63 +498,10 @@ jobs:
494498
run: |
495499
docker run --rm \
496500
-v devnet_filecoin-proofs:/proofs \
497-
-v $FIL_PROOFS_PARAMETER_CACHE:/cache \
498-
$SHELL_IMAGE \
501+
-v "$FIL_PROOFS_PARAMETER_CACHE":/cache \
502+
"$SHELL_IMAGE" \
499503
sh -c "cp /proofs/* /cache"
500-
sudo chmod -R 755 $FIL_PROOFS_PARAMETER_CACHE
501-
local-devnet-curio-check:
502-
# Disabling this job as it is not providing any value until the curio setup is fixed. See: https://github.com/ChainSafe/forest/issues/5171
503-
if: false
504-
name: Devnet Curio checks
505-
runs-on: ubuntu-24.04
506-
needs:
507-
- build-ubuntu
508-
env:
509-
# We use a custom Dockerfile for CI to speed up the build process.
510-
FOREST_DOCKERFILE_OVERRIDE: scripts/devnet/forest_ci.dockerfile
511-
steps:
512-
- uses: actions/cache@v5
513-
id: cache
514-
with:
515-
path: "${{ env.FIL_PROOFS_PARAMETER_CACHE }}"
516-
key: proof-params-2k
517-
- name: Load cache into volume
518-
if: steps.cache.outputs.cache-hit == 'true'
519-
run: |
520-
docker volume create devnet_filecoin-proofs
521-
docker run --rm \
522-
-v devnet_filecoin-proofs:/proofs \
523-
-v $FIL_PROOFS_PARAMETER_CACHE:/cache \
524-
$SHELL_IMAGE \
525-
sh -c "cp /cache/* /proofs"
526-
- uses: actions/checkout@v6
527-
- uses: actions/download-artifact@v8
528-
with:
529-
name: "forest-${{ runner.os }}"
530-
- name: Devnet setup
531-
run: |
532-
cp ./scripts/devnet/setup.sh ./scripts/devnet-curio/setup.sh
533-
chmod +x ./scripts/devnet-curio/setup.sh
534-
./scripts/devnet-curio/setup.sh
535-
timeout-minutes: ${{ fromJSON(env.SCRIPT_TIMEOUT_MINUTES) }}
536-
- name: Devnet check
537-
run: |
538-
cp ./scripts/devnet/check.sh ./scripts/devnet-curio/check.sh
539-
chmod +x ./scripts/devnet-curio/check.sh
540-
./scripts/devnet-curio/check.sh
541-
timeout-minutes: ${{ fromJSON(env.SCRIPT_TIMEOUT_MINUTES) }}
542-
- name: Dump docker logs
543-
if: always()
544-
uses: jwalton/gh-docker-logs@v2
545-
- name: Prepare cache folder for uploading
546-
if: steps.cache.outputs.cache-hit != 'true'
547-
run: |
548-
docker run --rm \
549-
-v devnet_filecoin-proofs:/proofs \
550-
-v $FIL_PROOFS_PARAMETER_CACHE:/cache \
551-
$SHELL_IMAGE \
552-
sh -c "cp /proofs/* /cache"
553-
sudo chmod -R 755 $FIL_PROOFS_PARAMETER_CACHE
504+
sudo chmod -R 755 "$FIL_PROOFS_PARAMETER_CACHE"
554505
bootstrap-checks-forest:
555506
needs:
556507
- build-ubuntu
@@ -663,8 +614,8 @@ jobs:
663614
if: always()
664615
run: |
665616
export WORKFLOW_URL="${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}"
666-
echo ${WORKFLOW_URL}
667-
echo "WORKFLOW_URL=${WORKFLOW_URL}" >> $GITHUB_ENV
617+
echo "${WORKFLOW_URL}"
618+
echo "WORKFLOW_URL=${WORKFLOW_URL}" >> "$GITHUB_ENV"
668619
- uses: JasonEtco/create-an-issue@v2
669620
if: github.ref == 'refs/heads/main' && failure()
670621
env:

0 commit comments

Comments
 (0)