Merge branch 'main' into hm/shed-miner-fees

Author: hanabi1224

.github/CARGO_ADVISORIES_ISSUE_TEMPLATE.md

@@ -0,0 +1,8 @@
+---
+title: "[automated] `cargo deny check advisories` failure @ {{ date | date('D/M/YY HH:mm') }}"
+labels: ["Bug"]
+---
+
+## Description
+
+Please [check the logs]({{ env.WORKFLOW_URL }}) for more information.

.github/workflows/cargo-advisories.yml

@@ -0,0 +1,26 @@
+name: cargo deny advisories
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: "0 0 * * *"
+jobs:
+  rpc-parity:
+    name: cargo deny advisories
+    runs-on: ubuntu-24.04-arm
+    steps:
+      - uses: actions/checkout@v4
+      - run: make install-cargo-binstall
+      - run: cargo binstall --no-confirm cargo-deny
+      - run: cargo deny check advisories
+      - name: Set WORKFLOW_URL
+        if: failure()
+        run: |
+          export WORKFLOW_URL="${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}"
+          echo ${WORKFLOW_URL}
+          echo "WORKFLOW_URL=${WORKFLOW_URL}" >> $GITHUB_ENV
+      - uses: JasonEtco/create-an-issue@v2
+        if: failure()
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          filename: .github/CARGO_ADVISORIES_ISSUE_TEMPLATE.md

.github/workflows/docs-auto-update.yml

@@ -25,6 +25,7 @@ jobs:
         uses: peter-evans/create-pull-request@v7
         with:
           base: main
+          branch: leshy/update-forest-docs
           token: ${{ secrets.ACTIONS_PAT }}
           commit-message: Update Forest CLI docs
           title: "[automated] Update Forest CLI docs"

.github/workflows/docs-required-override.yml

@@ -58,6 +58,16 @@ jobs:
                     - '!**.md'
                     - '!.github/workflows/docs-*.yml'
 
+  override_calibnet_rpc_checks:
+    name: Calibnet RPC checks
+    runs-on: ubuntu-24.04-arm
+    needs:
+      - changes-docs
+      - changes-not-docs
+    if: ${{ (needs.changes-docs.outputs.changesFound == 'true') && (needs.changes-not-docs.outputs.otherChangesFound == 'false') }}
+    steps:
+      - run: echo "No-op job to trigger the required checks."
+
   override_integration_tests:
     name: Integration tests status
     runs-on: ubuntu-24.04-arm

.github/workflows/forest.yml

@@ -8,6 +8,9 @@ on:
   pull_request:
     branches:
       - main
+    # This needs to be declared explicitly so that the RPC checks job is actually
+    # run when PR is labeled.
+    types: [opened, synchronize, reopened, labeled, unlabeled]
     paths-ignore:
       - 'docs/**'
       - '.github/workflows/docs-*.yml'
@@ -505,6 +508,54 @@ jobs:
       - name: Dump docker logs
         if: always()
         uses: jwalton/gh-docker-logs@v2
+  calibnet-rpc-checks-no-ops:
+    name: Calibnet RPC checks
+    runs-on: ubuntu-24.04-arm
+    if: ${{ !contains(github.event.pull_request.labels.*.name, 'RPC') }}
+    steps:
+      - run: echo "No-op job to trigger the required calibnet RPC checks."
+  calibnet-rpc-checks:
+    if: ${{ contains(github.event.pull_request.labels.*.name, 'RPC') }}
+    needs:
+      - build-ubuntu
+    name: Calibnet RPC checks
+    runs-on: ubuntu-24.04
+    env:
+      # We use a custom Dockerfile for CI to speed up the build process.
+      FOREST_DOCKERFILE_OVERRIDE: scripts/devnet/forest_ci.dockerfile
+    steps:
+      # Remove some unnecessary software to free up space. This should free up around 15-20 GB.
+      # This is required because of the limited space on the runner,
+      # and disk space-hungry snapshots used in the setup.
+      # This is taken from:
+      # https://github.com/easimon/maximize-build-space/blob/fc881a613ad2a34aca9c9624518214ebc21dfc0c/action.yml#L121-L136
+      # Using the action directly is not feasible as it does some more modifications that break the setup in our case.
+      -   name: Remove unnecessary software
+          run: |
+              echo "Disk space before cleanup"
+              df -h
+              sudo rm -rf /usr/share/dotnet
+              sudo rm -rf /usr/local/lib/android
+              sudo rm -rf /opt/ghc
+              sudo rm -rf /opt/hostedtoolcache/CodeQL
+              echo "Disk space after cleanup"
+              df -h
+      - uses: actions/checkout@v4
+      - uses: actions/download-artifact@v4
+        with:
+          name: 'forest-${{ runner.os }}'
+      - name: Run api compare tests
+        run: ./scripts/tests/api_compare/setup.sh
+        timeout-minutes: '${{ fromJSON(env.SCRIPT_TIMEOUT_MINUTES) }}'
+      - name: Dump docker logs
+        if: always()
+        uses: jwalton/gh-docker-logs@v2
+      - name: Dump Docker usage
+        if: always()
+        run: |
+          docker system df
+          docker system df --verbose
+          df -h
   # Umbrella job to aggregate all integration tests and get their status
   integration-tests-status:
     needs:

.github/workflows/lotus-api-bump.yml

@@ -32,6 +32,7 @@ jobs:
         uses: peter-evans/create-pull-request@v7
         with:
           base: main
+          branch: leshy/update-lotus-version
           token: ${{ secrets.ACTIONS_PAT }}
           commit-message: Update Lotus dependency
           title: "[automated] Update Lotus version in API tests"

.github/workflows/rpc-parity.yml

@@ -52,7 +52,7 @@ jobs:
           echo ${WORKFLOW_URL}
           echo "WORKFLOW_URL=${WORKFLOW_URL}" >> $GITHUB_ENV
       - uses: JasonEtco/create-an-issue@v2
-        if: failure()
+        if: github.ref == 'refs/heads/main' && failure()
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:

.github/workflows/rust-lint.yml

@@ -61,7 +61,7 @@ jobs:
           command: |
             sudo apt-get install -y libclang-dev # required dep for cargo-spellcheck
       - name: Install Lint tools
-        run: make install-lint-tools-ci-arm
+        run: make install-lint-tools-ci
         env:
           RUSTFLAGS: "-Cstrip=symbols"
       - run: make lint-all

.github/workflows/snapshot-parity.yml

@@ -23,7 +23,7 @@ jobs:
           echo ${WORKFLOW_URL}
           echo "WORKFLOW_URL=${WORKFLOW_URL}" >> $GITHUB_ENV
       - uses: JasonEtco/create-an-issue@v2
-        if: failure()
+        if: github.ref == 'refs/heads/main' && failure()
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:

CHANGELOG.md

@@ -26,15 +26,42 @@
 ## Forest unreleased
 
 ### Breaking
+- [#5559](https://github.com/ChainSafe/forest/pull/5559) Change `Filecoin.ChainGetMinBaseFee` to `Forest.ChainGetMinBaseFee` with read access.
 
 ### Added
 
 ### Changed
 
+- [#5467](https://github.com/ChainSafe/forest/pull/5467) Improve error message for `Filecoin.EthEstimateGas` and `Filecoin.EthCall`.
+
 ### Removed
 
 ### Fixed
 
+## Forest v0.25.3 "Sméagol"
+
+This is a non-mandatory, but highly recommended, release targeting the mainnet node operators. It includes a fix preventing the node from duplicate, costly migrations. Given the upcoming network upgrade state migration is expected to be slow, we recommend upgrading your Forest node before `Mon 14 Apr 23:00:00 UTC 2025`.
+
+### Fixed
+
+- [#5512](https://github.com/ChainSafe/forest/pull/5512) Fixed `Filecoin.EthTraceFilter` RPC method.
+- [#5517](https://github.com/ChainSafe/forest/issues/5517) Fix the `forest-cli sync wait` issue
+- [#5540](https://github.com/ChainSafe/forest/pull/5540) Avoid duplicate migrations.
+
+## Forest v0.25.2 "Fool of a Took"
+
+This is a mandatory release for mainnet and calibnet node operators. It introduces a fix upgrade for calibnet at epoch `2_558_014` which corresponds to `Mon  7 Apr 23:00:00 UTC 2025` and changes the mainnet upgrade epoch for the NV25 _Teep_ to `4_878_840` which corresponds to `Mon 14 Apr 23:00:00 UTC 2025`.
+
+See [here](https://github.com/filecoin-project/community/discussions/74#discussioncomment-12720764) for details on the issue.
+
+### Changed
+
+- [#5515](https://github.com/ChainSafe/forest/pull/5515) Changed the mainnet upgrade epoch for the NV25 _Teep_ to `4_878_840` which corresponds to `Mon 14 Apr 23:00:00 UTC 2025`.
+
+### Fixed
+
+- [#5515](https://github.com/ChainSafe/forest/pull/5515) Introduced a fix network upgrade for the calibnet `Tock`.
+
 ## Forest v0.25.1 "Goldberry"
 
 This is a mandatory release for mainnet node operators. It includes the NV25 _Teep_ network upgrade at epoch `4_867_320` which corresponds to `10 Apr 23:00:00 UTC 2025`. This release also includes a few fixes, most notably a database migration speed up that used to give certain important people a massive headache. Forest Prometheus metrics have been cleaned and you can look them up in the [documentation](https://docs.forest.chainsafe.io/reference/metrics).