Commit bcb271a
log: review fixes — AsyncAppend ziggy rewrite, bug fixes
AsyncAppend (full rewrite):
- Non-generic struct with allocator-based pre-allocation (zero hot-path alloc)
- Cache-line aligned cursors (128B) to prevent false sharing
- Epoch-based condvar parking replaces spin+sleep consumer loop
- Wrapping arithmetic (+%) throughout for long-running correctness
- Better memory orderings (monotonic for cursors, release/acquire for sequences)
- @bitcast diff calculation replaces @intcast overflow risk
Bug fixes from adversarial review:
- EnvFilter.fromEnv(): use std.posix.getenv (process-lifetime pointer)
instead of getEnvVarOwned into stack buffer (was use-after-free)
- Dispatcher.emit(): save/restore diag_attrs.len across fan-out dispatches
(diagnostic enrichment was contaminating subsequent dispatches)
- JsonLayout: escape all control chars U+0000-U+001F per RFC 8259 §7
- LogfmtLayout: escape \r and \t (needsQuoting detected them but
writeLogfmtEscaped didn't handle them)
Prior auto-fixes included:
- Record.zig: AttrIterator.next() rewritten from recursion to while loop
- comptime_checks.zig: doc strings fixed *Self → *const Self
- root.zig: global dispatcher redesigned with single atomic pointer swap
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent a68c354 commit bcb271a
File tree
2,567 files changed
+21165
-199
lines changed- .claude/worktrees
- .github/agents
- .idea
- .remember
- logs/autonomous
- tmp
- docs/plans
- fork-choice
- src/log
- zig-pkg
- N-V-__8AAD7KDwAJhkERKP7udCdwtbZyt7nOUr8-MibaEgCN
- .github/workflows
- examples
- src
- tests
- blst_zig-0.0.0-cnAxzg4LAACIXTmj0X4unkf0FCYcFTZVzDdWE32PZl_A
- hashtree-0.1.0-sBOovvQTAADvFx7ywy2dNIfryDr44T6tWJxtkF0sQpG7
- src
- snappy-0.1.0-n4AaqsA4AADR1GK5fReGMaaNyLsXRuarYpwqmVsbmvPk
- src
- zig_yaml-0.1.0-C1161pOKAgAhsmZ2SAjaQ2cIzaccoi5dn4x6UmsN0eC_
- src
- Parser
- Yaml
- test
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
2,567 files changed
+21165
-199
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
Whitespace-only changes.
Whitespace-only changes.
Whitespace-only changes.
0 commit comments