feat: allow multiple mnemonic index ranges in validator setup (#8731)

**Motivation**

- @philknows wants

**Description**

- allow multiple index ranges in validator
- this should only be used in testing and not in production

Author: wemeetagain

packages/cli/src/cmds/dev/options.ts

@@ -1,13 +1,14 @@
 import {CliCommandOptions, CliOptionDefinition} from "@lodestar/utils";
 import {NetworkName} from "../../networks/index.js";
 import {beaconNodeOptions, globalOptions} from "../../options/index.js";
+import {parseRange} from "../../util/format.ts";
 import {BeaconArgs, beaconOptions} from "../beacon/options.js";
 import {IValidatorCliArgs, validatorOptions} from "../validator/options.js";
 
 type IDevOwnArgs = {
   genesisEth1Hash?: string;
   genesisValidators: number;
-  startValidators?: string;
+  startValidators?: number[];
   genesisTime?: number;
   reset?: boolean;
   dumpTestnetFiles?: string;
@@ -29,8 +30,13 @@ const devOwnOptions: CliCommandOptions<IDevOwnArgs> = {
   },
 
   startValidators: {
-    description: "Start interop validators in inclusive range with notation '0..7'",
-    type: "string",
+    description: "Start interop validators in inclusive range(s) with notation '0..7'",
+    type: "array",
+    coerce: (indexes: string[]): number[] =>
+      // Parse ["11..13,15..17"] to ["11..13", "15..17"]
+      indexes
+        .flatMap((item) => item.split(","))
+        .flatMap(parseRange),
     group: "dev",
   },
 

packages/cli/src/cmds/validator/options.ts

@@ -3,7 +3,7 @@ import {CliCommandOptions} from "@lodestar/utils";
 import {defaultOptions} from "@lodestar/validator";
 import {coerceCors, enabledAllBashFriendly} from "../../options/beaconNodeOptions/api.js";
 import {LogArgs, logOptions} from "../../options/logOptions.js";
-import {ensure0xPrefix} from "../../util/index.js";
+import {ensure0xPrefix, parseRange} from "../../util/index.js";
 import {keymanagerRestApiServerOptsDefault} from "./keymanager/server.js";
 import {defaultAccountPaths, defaultValidatorPaths} from "./paths.js";
 
@@ -70,9 +70,9 @@ export type IValidatorCliArgs = AccountValidatorArgs &
 
     distributed?: boolean;
 
-    interopIndexes?: string;
+    interopIndexes?: number[];
     fromMnemonic?: string;
-    mnemonicIndexes?: string;
+    mnemonicIndexes?: number[];
 
     metrics?: boolean;
     "metrics.port"?: number;
@@ -453,8 +453,13 @@ export const validatorOptions: CliCommandOptions<IValidatorCliArgs> = {
 
   interopIndexes: {
     hidden: true,
-    description: "Range (inclusive) of interop key indexes to validate with: 0..16",
-    type: "string",
+    description: "Range(s) (inclusive) of interop key indexes to validate with: 0..16",
+    type: "array",
+    coerce: (indexes: string[]): number[] =>
+      // Parse ["11..13,15..17"] to ["11..13", "15..17"]
+      indexes
+        .flatMap((item) => item.split(","))
+        .flatMap(parseRange),
   },
 
   fromMnemonic: {
@@ -465,7 +470,12 @@ export const validatorOptions: CliCommandOptions<IValidatorCliArgs> = {
 
   mnemonicIndexes: {
     hidden: true,
-    description: "UNSAFE. Range (inclusive) of mnemonic key indexes to validate with: 0..16",
-    type: "string",
+    description: "UNSAFE. Range(s) (inclusive) of mnemonic key indexes to validate with: 0..16",
+    type: "array",
+    coerce: (indexes: string[]): number[] =>
+      // Parse ["11..13,15..17"] to ["11..13", "15..17"]
+      indexes
+        .flatMap((item) => item.split(","))
+        .flatMap(parseRange),
   },
 };

packages/cli/src/cmds/validator/signers/index.ts

@@ -5,7 +5,7 @@ import {interopSecretKey} from "@lodestar/state-transition";
 import {LogLevel, Logger, isValidHttpUrl} from "@lodestar/utils";
 import {Signer, SignerType, externalSignerGetKeys} from "@lodestar/validator";
 import {GlobalArgs, defaultNetwork} from "../../../options/index.js";
-import {YargsError, assertValidPubkeysHex, parseRange} from "../../../util/index.js";
+import {YargsError, assertValidPubkeysHex} from "../../../util/index.js";
 import {showProgress} from "../../../util/progress.js";
 import {decryptKeystoreDefinitions} from "../keymanager/decryptKeystoreDefinitions.js";
 import {PersistedKeysBackend} from "../keymanager/persistedKeys.js";
@@ -49,7 +49,7 @@ export async function getSignersFromArgs(
 
   // ONLY USE FOR TESTNETS - Derive interop keys
   if (args.interopIndexes) {
-    const indexes = parseRange(args.interopIndexes);
+    const indexes = args.interopIndexes;
     // Using a remote signer with TESTNETS
     if (args["externalSigner.pubkeys"] || args["externalSigner.fetch"]) {
       return getRemoteSigners(args);
@@ -67,7 +67,7 @@ export async function getSignersFromArgs(
     }
 
     const masterSK = deriveKeyFromMnemonic(args.fromMnemonic);
-    const indexes = parseRange(args.mnemonicIndexes);
+    const indexes = Array.from(new Set(args.mnemonicIndexes));
     return indexes.map((index) => ({
       type: SignerType.Local,
       secretKey: SecretKey.fromBytes(deriveEth2ValidatorKeys(masterSK, index).signing),