chore: fix and add workaround on params e2e tests

Author: ensi321

packages/beacon-node/test/spec/presets/operations.test.ts

@@ -92,8 +92,7 @@ const operationFns: Record<string, BlockProcessFn<CachedBeaconStateAllForks>> =
   },
 
   deposit_request: (state, testCase: {deposit_request: electra.DepositRequest}) => {
-    const fork = state.config.getForkSeq(state.slot);
-    blockFns.processDepositRequest(fork, state as CachedBeaconStateElectra, testCase.deposit_request);
+    blockFns.processDepositRequest(state as CachedBeaconStateElectra, testCase.deposit_request);
   },
 
   consolidation_request: (state, testCase: {consolidation_request: electra.ConsolidationRequest}) => {

packages/params/test/e2e/ensure-config-is-synced.test.ts

@@ -8,7 +8,13 @@ import {loadConfigYaml} from "../yaml.js";
 // Not e2e, but slow. Run with e2e tests
 
 /** https://github.com/ethereum/consensus-specs/releases */
-const specConfigCommit = "v1.5.0-alpha.3";
+const specConfigCommit = "v1.5.0-alpha.8";
+/**
+ * Fields that we filter from local config when doing comparison.
+ * Ideally this should be empty as it is not spec compliant
+ * For `MAX_BLOBS_PER_BLOCK`, see https://github.com/ChainSafe/lodestar/issues/7172
+ */
+const ignoredLocalPresetFields: (keyof BeaconPreset)[] = ["MAX_BLOBS_PER_BLOCK"];
 
 describe("Ensure config is synced", () => {
   vi.setConfig({testTimeout: 60 * 1000});
@@ -25,12 +31,22 @@ describe("Ensure config is synced", () => {
 });
 
 function assertCorrectPreset(localPreset: BeaconPreset, remotePreset: BeaconPreset): void {
+  const filteredLocalPreset: Partial<BeaconPreset> = Object.keys(localPreset)
+    .filter((key) => !ignoredLocalPresetFields.includes(key as keyof BeaconPreset))
+    .reduce(
+      (acc, key) => {
+        acc[key as keyof BeaconPreset] = localPreset[key as keyof BeaconPreset];
+        return acc;
+      },
+      {} as Partial<BeaconPreset>
+    );
+
   // Check each key for better debuggability
   for (const key of Object.keys(remotePreset) as (keyof BeaconPreset)[]) {
-    expect(localPreset[key]).toBe(remotePreset[key]);
+    expect(filteredLocalPreset[key]).toBe(remotePreset[key]);
   }
 
-  expect(localPreset).toEqual(remotePreset);
+  expect(filteredLocalPreset).toEqual(remotePreset);
 }
 
 async function downloadRemoteConfig(preset: "mainnet" | "minimal", commit: string): Promise<BeaconPreset> {

packages/state-transition/src/block/processDeposit.ts

@@ -55,11 +55,11 @@ export function applyDeposit(
   state: CachedBeaconStateAllForks,
   deposit: DepositData | DepositRequest
 ): void {
-  const {config, epochCtx} = state;
+  const {config, epochCtx, validators} = state;
   const {pubkey, withdrawalCredentials, amount, signature} = deposit;
 
   const cachedIndex = epochCtx.getValidatorIndex(pubkey);
-  const isNewValidator = cachedIndex === null || !Number.isSafeInteger(cachedIndex);
+  const isNewValidator = cachedIndex === null || !Number.isSafeInteger(cachedIndex) || cachedIndex >= validators.length;
 
   if (fork < ForkSeq.electra) {
     if (isNewValidator) {

packages/state-transition/src/block/processDepositRequest.ts

@@ -3,11 +3,7 @@ import {ForkSeq, UNSET_DEPOSIT_REQUESTS_START_INDEX} from "@lodestar/params";
 
 import {CachedBeaconStateElectra} from "../types.js";
 
-export function processDepositRequest(
-  fork: ForkSeq,
-  state: CachedBeaconStateElectra,
-  depositRequest: electra.DepositRequest
-): void {
+export function processDepositRequest(state: CachedBeaconStateElectra, depositRequest: electra.DepositRequest): void {
   if (state.depositRequestsStartIndex === UNSET_DEPOSIT_REQUESTS_START_INDEX) {
     state.depositRequestsStartIndex = BigInt(depositRequest.index);
   }

packages/state-transition/src/block/processOperations.ts

@@ -68,7 +68,7 @@ export function processOperations(
     const bodyElectra = body as electra.BeaconBlockBody;
 
     for (const depositRequest of bodyElectra.executionRequests.deposits) {
-      processDepositRequest(fork, stateElectra, depositRequest);
+      processDepositRequest(stateElectra, depositRequest);
     }
 
     for (const elWithdrawalRequest of bodyElectra.executionRequests.withdrawals) {