Skip to content

Commit f2737cf

Browse files
committed
move to max request data columns to preset
1 parent 507a2f4 commit f2737cf

File tree

9 files changed

+8
-6
lines changed

9 files changed

+8
-6
lines changed

packages/config/src/chainConfig/configs/mainnet.ts

-1
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ export const chainConfig: ChainConfig = {
105105

106106
// Electra
107107
DATA_COLUMN_SIDECAR_SUBNET_COUNT: 32,
108-
MAX_REQUEST_DATA_COLUMN_SIDECARS: 16384,
109108
SAMPLES_PER_SLOT: 8,
110109
CUSTODY_REQUIREMENT: 1,
111110
};

packages/config/src/chainConfig/configs/minimal.ts

-1
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ export const chainConfig: ChainConfig = {
103103

104104
// Electra
105105
DATA_COLUMN_SIDECAR_SUBNET_COUNT: 32,
106-
MAX_REQUEST_DATA_COLUMN_SIDECARS: 16384,
107106
SAMPLES_PER_SLOT: 8,
108107
CUSTODY_REQUIREMENT: 1,
109108
};

packages/config/src/chainConfig/types.ts

-2
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ export type ChainConfig = {
7474
MIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTS: number;
7575

7676
DATA_COLUMN_SIDECAR_SUBNET_COUNT: number;
77-
MAX_REQUEST_DATA_COLUMN_SIDECARS: number;
7877
SAMPLES_PER_SLOT: number;
7978
CUSTODY_REQUIREMENT: number;
8079
};
@@ -141,7 +140,6 @@ export const chainConfigTypes: SpecTypes<ChainConfig> = {
141140
MIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTS: "number",
142141

143142
DATA_COLUMN_SIDECAR_SUBNET_COUNT: "number",
144-
MAX_REQUEST_DATA_COLUMN_SIDECARS: "number",
145143
SAMPLES_PER_SLOT: "number",
146144
CUSTODY_REQUIREMENT: "number",
147145
};

packages/params/src/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ export const {
9797
FIELD_ELEMENTS_PER_CELL,
9898
FIELD_ELEMENTS_PER_EXT_BLOB,
9999
KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH,
100+
MAX_REQUEST_DATA_COLUMN_SIDECARS,
100101
} = activePreset;
101102

102103
////////////

packages/params/src/presets/mainnet.ts

+1
Original file line numberDiff line numberDiff line change
@@ -124,4 +124,5 @@ export const mainnetPreset: BeaconPreset = {
124124
FIELD_ELEMENTS_PER_CELL: 64,
125125
FIELD_ELEMENTS_PER_EXT_BLOB: 8192,
126126
KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH: 4,
127+
MAX_REQUEST_DATA_COLUMN_SIDECARS: 16384,
127128
};

packages/params/src/presets/minimal.ts

+1
Original file line numberDiff line numberDiff line change
@@ -125,4 +125,5 @@ export const minimalPreset: BeaconPreset = {
125125
FIELD_ELEMENTS_PER_CELL: 64,
126126
FIELD_ELEMENTS_PER_EXT_BLOB: 8192,
127127
KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH: 4,
128+
MAX_REQUEST_DATA_COLUMN_SIDECARS: 16384,
128129
};

packages/params/src/types.ts

+2
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ export type BeaconPreset = {
8888
FIELD_ELEMENTS_PER_CELL: number;
8989
FIELD_ELEMENTS_PER_EXT_BLOB: number;
9090
KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH: number;
91+
MAX_REQUEST_DATA_COLUMN_SIDECARS: number;
9192
};
9293

9394
/**
@@ -179,6 +180,7 @@ export const beaconPresetTypes: BeaconPresetTypes = {
179180
FIELD_ELEMENTS_PER_CELL: "number",
180181
FIELD_ELEMENTS_PER_EXT_BLOB: "number",
181182
KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH: "number",
183+
MAX_REQUEST_DATA_COLUMN_SIDECARS: "number",
182184
};
183185

184186
type BeaconPresetTypes = {

packages/types/src/electra/sszTypes.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,14 @@ import {
55
MAX_BLOB_COMMITMENTS_PER_BLOCK,
66
NUMBER_OF_COLUMNS,
77
KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH,
8+
MAX_REQUEST_DATA_COLUMN_SIDECARS,
89
} from "@lodestar/params";
910

1011
import {ssz as primitiveSsz} from "../primitive/index.js";
1112
import {ssz as phase0Ssz} from "../phase0/index.js";
1213
import {ssz as denebSsz} from "../deneb/index.js";
1314

14-
const {BLSSignature, Root, ColumnIndex, Bytes32} = primitiveSsz;
15+
const {BLSSignature, Root, ColumnIndex, Bytes32, Slot, UintNum64} = primitiveSsz;
1516

1617
export const Cell = new ByteVectorType(BYTES_PER_FIELD_ELEMENT * FIELD_ELEMENTS_PER_CELL);
1718
export const DataColumn = new ListCompositeType(Cell, MAX_BLOB_COMMITMENTS_PER_BLOCK);

packages/validator/src/util/params.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -228,10 +228,10 @@ function getSpecCriticalParams(localConfig: ChainConfig): Record<keyof ConfigWit
228228
FIELD_ELEMENTS_PER_CELL: electraForkRelevant,
229229
FIELD_ELEMENTS_PER_EXT_BLOB: electraForkRelevant,
230230
KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH: electraForkRelevant,
231+
MAX_REQUEST_DATA_COLUMN_SIDECARS: electraForkRelevant,
231232

232233
// Electra
233234
DATA_COLUMN_SIDECAR_SUBNET_COUNT: electraForkRelevant,
234-
MAX_REQUEST_DATA_COLUMN_SIDECARS: electraForkRelevant,
235235
SAMPLES_PER_SLOT: electraForkRelevant,
236236
CUSTODY_REQUIREMENT: electraForkRelevant,
237237
};

0 commit comments

Comments
 (0)