Skip to content

Commit 7c33583

Browse files
authored
Fix: Compile time issues (#87)
* Fixed unresolved auth.TagManager * Fixed other compile time issues
1 parent 7fd6816 commit 7c33583

File tree

9 files changed

+38
-26
lines changed

9 files changed

+38
-26
lines changed

go.mod

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module github.com/ChargePi/ChargePi-go
33
go 1.22.1
44

55
require (
6-
github.com/ChargePi/ocppManager-go v1.1.3
6+
github.com/ChargePi/ocppManager-go v1.2.0
77
github.com/agrison/go-commons-lang v0.0.0-20240106075236-2e001e6401ef
88
github.com/avast/retry-go v3.0.0+incompatible
99
github.com/casbin/casbin/v2 v2.98.0
@@ -19,7 +19,7 @@ require (
1919
github.com/golang/protobuf v1.5.4
2020
github.com/google/uuid v1.6.0
2121
github.com/grpc-ecosystem/go-grpc-middleware v1.4.0
22-
github.com/lorenzodonini/ocpp-go v0.18.0
22+
github.com/lorenzodonini/ocpp-go v0.19.0
2323
github.com/mandrigin/gin-spa v0.0.0-20200212133200-790d0c0c7335
2424
github.com/nicksnyder/go-i18n/v2 v2.2.1
2525
github.com/op/go-logging v0.0.0-20160315200505-970db520ece7 // indirect
@@ -28,7 +28,7 @@ require (
2828
github.com/sirupsen/logrus v1.9.3
2929
github.com/spf13/cobra v1.8.1
3030
github.com/spf13/viper v1.19.0
31-
github.com/stretchr/testify v1.9.0
31+
github.com/stretchr/testify v1.10.0
3232
github.com/tavsec/gin-healthcheck v1.6.3
3333
github.com/warthog618/gpiod v0.8.2
3434
golang.org/x/net v0.29.0
@@ -73,8 +73,8 @@ require (
7373
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
7474
github.com/golang/snappy v0.0.4 // indirect
7575
github.com/google/flatbuffers v1.12.1 // indirect
76-
github.com/gorilla/mux v1.7.3 // indirect
77-
github.com/gorilla/websocket v1.4.1 // indirect
76+
github.com/gorilla/mux v1.8.1 // indirect
77+
github.com/gorilla/websocket v1.5.3 // indirect
7878
github.com/hashicorp/errwrap v1.1.0 // indirect
7979
github.com/hashicorp/go-multierror v1.1.1 // indirect
8080
github.com/hashicorp/hcl v1.0.0 // indirect
@@ -95,7 +95,7 @@ require (
9595
github.com/pelletier/go-toml/v2 v2.2.2 // indirect
9696
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
9797
github.com/redis/go-redis/v9 v9.6.1 // indirect
98-
github.com/relvacode/iso8601 v1.3.0 // indirect
98+
github.com/relvacode/iso8601 v1.6.0 // indirect
9999
github.com/robfig/cron/v3 v3.0.1 // indirect
100100
github.com/sagikazarmark/locafero v0.4.0 // indirect
101101
github.com/sagikazarmark/slog-shim v0.1.0 // indirect

go.sum

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ github.com/BurntSushi/toml v1.3.2 h1:o7IhLm0Msx3BaB+n3Ag7L8EVlByGnpq14C4YWiu/gL8
99
github.com/BurntSushi/toml v1.3.2/go.mod h1:CxXYINrC8qIiEnFrOxCa7Jy5BFHlXnUU2pbicEuybxQ=
1010
github.com/ChargePi/ocppManager-go v1.1.3 h1:rZRvVb4Va7zdTnzMQDwgyrHh0oxdIH8A3pAT80fqcbY=
1111
github.com/ChargePi/ocppManager-go v1.1.3/go.mod h1:I6eP6TjZu7QXis/lXHG4v0n6XdFTqix2EYxidDoh6Kk=
12+
github.com/ChargePi/ocppManager-go v1.2.0 h1:OV90kAD22yVYTSE+uHIgTtiwUOYpEwyHDPJb8d6AltM=
13+
github.com/ChargePi/ocppManager-go v1.2.0/go.mod h1:7kWtV1+qQw+OSOHBuE/wUsTH5Id5+/euzsCfke9NQ2E=
1214
github.com/DATA-DOG/go-sqlmock v1.5.2 h1:OcvFkGmslmlZibjAjaHm3L//6LiuBgolP7OputlJIzU=
1315
github.com/DATA-DOG/go-sqlmock v1.5.2/go.mod h1:88MAG/4G7SMwSE3CeA0ZKzrT5CiOU3OJ+JlNzwDqpNU=
1416
github.com/OneOfOne/xxhash v1.2.2 h1:KMrpdQIwFcEqXDklaen+P1axHaj9BSKzvpUUfnHldSE=
@@ -33,6 +35,8 @@ github.com/bytedance/sonic v1.11.6 h1:oUp34TzMlL+OY1OUWxHqsdkgC/Zfc85zGqw9siXjrc
3335
github.com/bytedance/sonic v1.11.6/go.mod h1:LysEHSvpvDySVdC2f87zGWf6CIKJcAvqab1ZaiQtds4=
3436
github.com/bytedance/sonic/loader v0.1.1 h1:c+e5Pt1k/cy5wMveRDyk2X4B9hF4g7an8N3zCYjJFNM=
3537
github.com/bytedance/sonic/loader v0.1.1/go.mod h1:ncP89zfokxS5LZrJxl5z0UJcsk4M4yY2JpfqGeCtNLU=
38+
github.com/caarlos0/env/v11 v11.3.1 h1:cArPWC15hWmEt+gWk7YBi7lEXTXCvpaSdCiZE2X5mCA=
39+
github.com/caarlos0/env/v11 v11.3.1/go.mod h1:qupehSf/Y0TUTsxKywqRt/vJjN5nz6vauiYEUUr8P4U=
3640
github.com/casbin/casbin/v2 v2.98.0 h1:xjsnyQh1hhw5kYTZJTGh4K+pxXhPgYhcr+X7zEbEB4o=
3741
github.com/casbin/casbin/v2 v2.98.0/go.mod h1:G2UyxPbyyrClPvzHQ4Yog6rtTz0x+Y2lc8qOwfqWLuc=
3842
github.com/casbin/govaluate v1.2.0 h1:wXCXFmqyY+1RwiKfYo3jMKyrtZmOL3kHwaqDyCPOYak=
@@ -159,10 +163,10 @@ github.com/google/uuid v1.1.2/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+
159163
github.com/google/uuid v1.4.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
160164
github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
161165
github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
162-
github.com/gorilla/mux v1.7.3 h1:gnP5JzjVOuiZD07fKKToCAOjS0yOpj/qPETTXCCS6hw=
163-
github.com/gorilla/mux v1.7.3/go.mod h1:1lud6UwP+6orDFRuTfBEV8e9/aOM/c4fVVCaMa2zaAs=
164-
github.com/gorilla/websocket v1.4.1 h1:q7AeDBpnBk8AogcD4DSag/Ukw/KV+YhzLj2bP5HvKCM=
165-
github.com/gorilla/websocket v1.4.1/go.mod h1:YR8l580nyteQvAITg2hZ9XVh4b55+EU/adAjf1fMHhE=
166+
github.com/gorilla/mux v1.8.1 h1:TuBL49tXwgrFYWhqrNgrUNEY92u81SPhu7sTdzQEiWY=
167+
github.com/gorilla/mux v1.8.1/go.mod h1:AKf9I4AEqPTmMytcMc0KkNouC66V3BtZ4qD5fmWSiMQ=
168+
github.com/gorilla/websocket v1.5.3 h1:saDtZ6Pbx/0u+bgYQ3q96pZgCzfhKXGPqt7kZ72aNNg=
169+
github.com/gorilla/websocket v1.5.3/go.mod h1:YR8l580nyteQvAITg2hZ9XVh4b55+EU/adAjf1fMHhE=
166170
github.com/grpc-ecosystem/go-grpc-middleware v1.4.0 h1:UH//fgunKIs4JdUbpDl1VZCDaL56wXCB/5+wF6uHfaI=
167171
github.com/grpc-ecosystem/go-grpc-middleware v1.4.0/go.mod h1:g5qyo/la0ALbONm6Vbp88Yd8NsDy6rZz+RcrMPxvld8=
168172
github.com/hashicorp/errwrap v1.0.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
@@ -209,8 +213,8 @@ github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
209213
github.com/leodido/go-urn v1.1.0/go.mod h1:+cyI34gQWZcE1eQU7NVgKkkzdXDQHr1dBMtdAPozLkw=
210214
github.com/leodido/go-urn v1.4.0 h1:WT9HwE9SGECu3lg4d/dIA+jxlljEa1/ffXKmRjqdmIQ=
211215
github.com/leodido/go-urn v1.4.0/go.mod h1:bvxc+MVxLKB4z00jd1z+Dvzr47oO32F/QSNjSBOlFxI=
212-
github.com/lorenzodonini/ocpp-go v0.18.0 h1:XhsKAzrG/1QJym2SYyiwTzr4cOa8geN8qSid3MFuiQ4=
213-
github.com/lorenzodonini/ocpp-go v0.18.0/go.mod h1:ZynYDWGw6CslG3vyPuucLsy6AyE+h3XXYlr39jhNiQY=
216+
github.com/lorenzodonini/ocpp-go v0.19.0 h1:THNriVV3bUWkGzaIkDeytcgoeBRjoN9ezPHsddIDfgc=
217+
github.com/lorenzodonini/ocpp-go v0.19.0/go.mod h1:2kcukDdhui4u730VfnYVWuwzDLgw+mBRGDir/QAyBhg=
214218
github.com/magiconair/properties v1.8.0/go.mod h1:PppfXfuXeibc/6YijjN8zIbojt8czPbwD3XqdrwzmxQ=
215219
github.com/magiconair/properties v1.8.7 h1:IeQXZAiQcpL9mgcAe1Nu6cX9LLw6ExEHKjN0VQdvPDY=
216220
github.com/magiconair/properties v1.8.7/go.mod h1:Dhd985XPs7jluiymwWYZ0G4Z61jb3vdS329zhj2hYo0=
@@ -252,8 +256,8 @@ github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2/go.mod h1:iKH
252256
github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4/go.mod h1:xMI15A0UPsDsEKsMN9yxemIoYk6Tm2C1GtYGdfGttqA=
253257
github.com/redis/go-redis/v9 v9.6.1 h1:HHDteefn6ZkTtY5fGUE8tj8uy85AHk6zP7CpzIAM0y4=
254258
github.com/redis/go-redis/v9 v9.6.1/go.mod h1:0C0c6ycQsdpVNQpxb1njEQIqkx5UcsM8FJCQLgE9+RA=
255-
github.com/relvacode/iso8601 v1.3.0 h1:HguUjsGpIMh/zsTczGN3DVJFxTU/GX+MMmzcKoMO7ko=
256-
github.com/relvacode/iso8601 v1.3.0/go.mod h1:FlNp+jz+TXpyRqgmM7tnzHHzBnz776kmAH2h3sZCn0I=
259+
github.com/relvacode/iso8601 v1.6.0 h1:eFXUhMJN3Gz8Rcq82f9DTMW0svjtAVuIEULglM7QHTU=
260+
github.com/relvacode/iso8601 v1.6.0/go.mod h1:FlNp+jz+TXpyRqgmM7tnzHHzBnz776kmAH2h3sZCn0I=
257261
github.com/robfig/cron/v3 v3.0.1 h1:WdRxkvbJztn8LMz/QEvLN5sBU+xKpSqwwUO1Pjr4qDs=
258262
github.com/robfig/cron/v3 v3.0.1/go.mod h1:eQICP3HwyT7UooqI/z+Ov+PtYAWygg1TEWWzGIFLtro=
259263
github.com/rogpeppe/go-internal v1.6.1/go.mod h1:xXDCJY+GAPziupqXw64V24skbSoqbTEfhy4qGm1nDQc=
@@ -312,6 +316,7 @@ github.com/stretchr/testify v1.8.2/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o
312316
github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
313317
github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg=
314318
github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
319+
github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
315320
github.com/subosito/gotenv v1.6.0 h1:9NlTDc1FTs4qu0DDq7AEtTPNw6SVm7uBMsUCUjABIf8=
316321
github.com/subosito/gotenv v1.6.0/go.mod h1:Dk4QP5c2W3ibzajGcXpNraDfq2IrhjMIvMSWPKKo0FU=
317322
github.com/tarm/serial v0.0.0-20180830185346-98f6abe2eb07/go.mod h1:kDXzergiv9cbyO7IOYJZWg1U88JhDg3PB6klq9Hg2pA=

internal/api/grpc/auth.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ import (
1212

1313
type AuthService struct {
1414
grpc.UnimplementedTagServer
15-
tagManager auth.TagManager
15+
tagManager auth.Manager
1616
}
1717

18-
func NewAuthService(tagManager auth.TagManager) *AuthService {
18+
func NewAuthService(tagManager auth.Manager) *AuthService {
1919
return &AuthService{
2020
tagManager: tagManager,
2121
}

internal/api/grpc/server.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@ package grpc
22

33
import (
44
"context"
5-
"github.com/ChargePi/ChargePi-go/internal/evse/manager"
65
"net"
76

7+
"github.com/ChargePi/ChargePi-go/internal/evse/manager"
8+
89
"github.com/ChargePi/ChargePi-go/internal/auth"
910
"github.com/ChargePi/ChargePi-go/internal/pkg/models/charge-point"
1011
"github.com/ChargePi/ChargePi-go/internal/pkg/models/settings"
@@ -34,7 +35,7 @@ type Server struct {
3435
func NewServer(
3536
settings settings.Api,
3637
point chargePoint.ChargePoint,
37-
authCache auth.TagManager,
38+
authCache auth.Manager,
3839
manager manager.Manager,
3940
settingsManager cfg.Manager,
4041
userService service.Service,

internal/auth/manager.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ package auth
22

33
import (
44
"errors"
5+
56
cache2 "github.com/ChargePi/ChargePi-go/internal/auth/cache"
67
"github.com/ChargePi/ChargePi-go/internal/auth/list"
7-
88
"github.com/dgraph-io/badger/v3"
99
"github.com/lorenzodonini/ocpp-go/ocpp1.6/localauth"
1010
"github.com/lorenzodonini/ocpp-go/ocpp1.6/types"

internal/chargepoint/charge-point.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package chargepoint
22

33
import (
44
"context"
5+
56
"github.com/ChargePi/ChargePi-go/internal/evse/manager"
67

78
"github.com/ChargePi/ChargePi-go/internal/auth"
@@ -55,7 +56,12 @@ func CreateChargePoint(
5556
switch protocolVersion {
5657
case ocpp.OCPP16:
5758
// Setup OCPP configuration from the database
58-
ocppVariableManager, err := ocpp_v16.NewV16ConfigurationManager(ocpp_v16.DefaultConfiguration(supportedOcppV16Profiles...), supportedOcppV16Profiles...)
59+
defaultOcppConfig, err := ocpp_v16.DefaultConfigurationFromProfiles(supportedOcppV16Profiles...)
60+
if err != nil {
61+
logger.WithError(err).Fatal("Cannot create OCPP configuration")
62+
}
63+
64+
ocppVariableManager, err := ocpp_v16.NewV16ConfigurationManager(*defaultOcppConfig, supportedOcppV16Profiles...)
5965
if err != nil {
6066
logger.WithError(err).Fatal("Cannot create OCPP configuration manager")
6167
}

internal/chargepoint/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@ package chargepoint
22

33
import (
44
"context"
5-
"github.com/ChargePi/ChargePi-go/internal/evse/manager"
65
"os"
76
"os/signal"
87
"time"
98

109
"github.com/ChargePi/ChargePi-go/internal/auth"
1110
"github.com/ChargePi/ChargePi-go/internal/diagnostics"
11+
"github.com/ChargePi/ChargePi-go/internal/evse/manager"
1212
"github.com/ChargePi/ChargePi-go/internal/pkg/database"
1313
"github.com/ChargePi/ChargePi-go/internal/pkg/models/charge-point"
1414
"github.com/ChargePi/ChargePi-go/internal/pkg/models/settings"

internal/chargepoint/v16/core-profile.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,9 @@ func (cp *ChargePoint) OnChangeConfiguration(request *core.ChangeConfigurationRe
5656

5757
// Process the change configuration request
5858
switch request.Key {
59-
case iso15118.ISO15118PnCEnabledConfigurationKey:
60-
// Check if any EVCC is supporting it
61-
// Update the key
59+
// case ocpp_v16.ISO15118PnCEnabledConfigurationKey:
60+
// Check if any EVCC is supporting it
61+
// Update the key
6262
case ocpp_v16.AuthorizeRemoteTxRequests.String():
6363
// Just update
6464
case ocpp_v16.AllowOfflineTxForUnknownId.String():
@@ -133,7 +133,7 @@ func (cp *ChargePoint) OnClearCache(request *core.ClearCacheRequest) (confirmati
133133

134134
func (cp *ChargePoint) OnDataTransfer(request *core.DataTransferRequest) (confirmation *core.DataTransferConfirmation, err error) {
135135
cp.logger.Infof("Received request %s", request.GetFeatureName())
136-
response := core.NewDataTransferConfirmation(core.DataTransferStatusRejected)
136+
response := core.DataTransferStatusRejected
137137

138138
// Supporting direct display control over custom data transfer messages, based on the messages in OCPP 2.0.1.
139139
if request.VendorId != cp.settingsManager.GetChargePointSettings().Info.OCPPDetails.Vendor {

internal/pkg/settings/exporter.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ type Exporter interface {
4646

4747
type ExporterImpl struct {
4848
db *badger.DB
49-
tagManager auth.TagManager
49+
tagManager auth.Manager
5050
settingsManager Manager
5151
logger log.FieldLogger
5252
}

0 commit comments

Comments
 (0)