Charts/issues/5197 - fixed host app crash by checking if the value is not NAN

sorinmiroiu97 · sorinmiroiu97 · commit 6d1cdfe148de · 2024-09-02T13:26:57.000+03:00
diff --git a/Source/Charts/Renderers/BarLineScatterCandleBubbleRenderer.swift b/Source/Charts/Renderers/BarLineScatterCandleBubbleRenderer.swift
@@ -67,7 +67,7 @@ open class BarLineScatterCandleBubbleRenderer: NSObject, DataRenderer
     {
         guard let data = dataProvider?.data else { return false }
         let count = CGFloat(dataProvider?.maxVisibleCount ?? 0) * viewPortHandler.scaleX
-        guard count < CGFloat.infinity else { return false }
+        guard count < CGFloat.infinity, !count.isNaN else { return false }
         return data.entryCount < Int(count)
     }
 
diff --git a/Source/Charts/Renderers/CombinedChartRenderer.swift b/Source/Charts/Renderers/CombinedChartRenderer.swift
@@ -163,7 +163,7 @@ open class CombinedChartRenderer: NSObject, DataRenderer
     {
         guard let data = dataProvider?.data else { return false }
         let count = CGFloat(dataProvider?.maxVisibleCount ?? 0) * viewPortHandler.scaleX
-        guard count < CGFloat.infinity else { return false }
+        guard count < CGFloat.infinity, !count.isNaN else { return false }
         return data.entryCount < Int(count)
     }
 
diff --git a/Source/Charts/Renderers/HorizontalBarChartRenderer.swift b/Source/Charts/Renderers/HorizontalBarChartRenderer.swift
@@ -616,7 +616,7 @@ open class HorizontalBarChartRenderer: BarChartRenderer
     {
         guard let data = dataProvider?.data else { return false }
         let count = CGFloat(dataProvider?.maxVisibleCount ?? 0) * viewPortHandler.scaleX
-        guard count < CGFloat.infinity else { return false }
+        guard count < CGFloat.infinity, !count.isNaN else { return false }
         return data.entryCount < Int(count)
     }
     
diff --git a/Source/Charts/Renderers/PieChartRenderer.swift b/Source/Charts/Renderers/PieChartRenderer.swift
@@ -590,7 +590,7 @@ open class PieChartRenderer: NSObject, DataRenderer
     {
         guard let data = dataProvider?.data else { return false }
         let count = CGFloat(dataProvider?.maxVisibleCount ?? 0) * viewPortHandler.scaleX
-        guard count < CGFloat.infinity else { return false }
+        guard count < CGFloat.infinity, !count.isNaN else { return false }
         return data.entryCount < Int(count)
     }
 

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ open class BarLineScatterCandleBubbleRenderer: NSObject, DataRenderer`
`67`	`67`	`{`
`68`	`68`	`guard let data = dataProvider?.data else { return false }`
`69`	`69`	`let count = CGFloat(dataProvider?.maxVisibleCount ?? 0) * viewPortHandler.scaleX`
`70`		`- guard count < CGFloat.infinity else { return false }`
	`70`	`+ guard count < CGFloat.infinity, !count.isNaN else { return false }`
`71`	`71`	`return data.entryCount < Int(count)`
`72`	`72`	`}`
`73`	`73`
Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ open class CombinedChartRenderer: NSObject, DataRenderer`
`163`	`163`	`{`
`164`	`164`	`guard let data = dataProvider?.data else { return false }`
`165`	`165`	`let count = CGFloat(dataProvider?.maxVisibleCount ?? 0) * viewPortHandler.scaleX`
`166`		`- guard count < CGFloat.infinity else { return false }`
	`166`	`+ guard count < CGFloat.infinity, !count.isNaN else { return false }`
`167`	`167`	`return data.entryCount < Int(count)`
`168`	`168`	`}`
`169`	`169`
Original file line number	Diff line number	Diff line change
`@@ -616,7 +616,7 @@ open class HorizontalBarChartRenderer: BarChartRenderer`
`616`	`616`	`{`
`617`	`617`	`guard let data = dataProvider?.data else { return false }`
`618`	`618`	`let count = CGFloat(dataProvider?.maxVisibleCount ?? 0) * viewPortHandler.scaleX`
`619`		`- guard count < CGFloat.infinity else { return false }`
	`619`	`+ guard count < CGFloat.infinity, !count.isNaN else { return false }`
`620`	`620`	`return data.entryCount < Int(count)`
`621`	`621`	`}`
`622`	`622`
Original file line number	Diff line number	Diff line change
`@@ -590,7 +590,7 @@ open class PieChartRenderer: NSObject, DataRenderer`
`590`	`590`	`{`
`591`	`591`	`guard let data = dataProvider?.data else { return false }`
`592`	`592`	`let count = CGFloat(dataProvider?.maxVisibleCount ?? 0) * viewPortHandler.scaleX`
`593`		`- guard count < CGFloat.infinity else { return false }`
	`593`	`+ guard count < CGFloat.infinity, !count.isNaN else { return false }`
`594`	`594`	`return data.entryCount < Int(count)`
`595`	`595`	`}`
`596`	`596`