eslint error 'NodeJS' is not defined no-undef

[huan]

@typescript-eslint/parser@4 cause this problem. (related commit: 4d7265a)

Downgrade it to v3 @typescript-eslint/parser@3 to solve the problem.

See: https://stackoverflow.com/q/64089216/1123955

[huan]

Monitor this problem to see when the upstream will fix it. (or other solutions)

[leolivier]

Hi, still no solution for that bug?
I'm in 4.28.2 and still the issue is here... I'd rather not downgrade to v3

[huan]

Unfortunately, I'm still working with v3 for all my projects...

Please let me know if you have any solutions, thanks and good luck!

[abarke]

I also upgraded to @typescript-eslint/parser@4.28.4

Work around for me was just to add it as a global in .eslintrc.js:

"globals": {
  "NodeJS": true
},

[leolivier]

Thanks @abarke, I will try this.
Meanwhile I just added an eslint "no check" comment inside my code for this declaration and it worked.

[leolivier]

I confirm your trick is working for too @abarke, thanks!

[thany]

Workaround is working. But since .eslintrc doesn't allow comments, I cannot link this issue in there in a comment, allowing me to keep track of why that global is there.

I suppose my project will have that workaround years after the issue has been fixed, because I will not be remembering each and every workaround, and their corresponding issue number, by heart...

So I guess it's really important to get this problem fixed sooner rather than later, especially seeing how old it already is. Or release a fix that allows comments. But I prefer the former over the latter, tbh.

[ITenthusiasm]

@thany Strangely enough, if you name files under .eslintrc.json (instead of .eslintrc), you can add comments to the file.

[il3ven]

A proper solution will be to turn off no-undef rule for typescript files. We need this rule for js not ts. This makes sense as typescript handles undefined variables. The project will not build if there are undefined variables. Add the following to your config:

overrides: [
  {
    files: ['*.ts'],
    rules: {
      'no-undef': 'off'
    }
  }
]

This is the recommended method by TypeScript ESLint. See here: https://typescript-eslint.io/docs/linting/troubleshooting/#i-get-errors-from-the-no-undef-rule-about-global-variables-not-being-defined-even-though-there-are-no-typescript-errors