Fix flaky test: automatic host removal job crashes on sites without login secret

The execute_host_removal_job cron job (running every minute in the
ui-job-scheduler) builds its automation_configs dict by iterating over
wato_site_ids(), which includes all remote sites with replication enabled
regardless of whether they have a login secret.

During composition tests, this creates a race window:
between the REST API call that creates a new
site connection (sites.create() writes site config to disk without a
secret) and the subsequent login call (sites.login() adds the secret),
the site is visible to the scheduler but has no secret. If the cron job
fires in that window records a crash report.

The composition tests detects this crash report in teardown and fails.
The failure is flaky because whether the cron job
coincides with the setup window is non-deterministic.

Every other cron job that contacts remote sites (execute_sync_remote_sites,
execute_host_label_sync_job) already guards against this by filtering
through sites_ready_for_remote_automation(), which requires "secret" to
be present. Apply the same guard to execute_host_removal_job by skipping
any site that is neither local nor has a secret configured.

Change-Id: Idb73bf0755eeb157a2969f438918ed7bd0bd4412

Author: DavidGerva

cmk/gui/watolib/automatic_host_removal.py

@@ -18,13 +18,16 @@
 
 import cmk.gui.log
 from cmk.ccc.hostaddress import HostName
-from cmk.ccc.site import SiteId
+from cmk.ccc.site import omd_site, SiteId
 from cmk.gui.config import Config
 from cmk.gui.exceptions import MKUserError
 from cmk.gui.http import Request
 from cmk.gui.i18n import _
 from cmk.gui.session import SuperUserContext
-from cmk.gui.site_config import is_distributed_setup_remote_site, wato_site_ids
+from cmk.gui.site_config import (
+    is_distributed_setup_remote_site,
+    sites_ready_for_remote_automation,
+)
 from cmk.gui.utils.roles import UserPermissionSerializableConfig
 from cmk.gui.watolib.activate_changes import ActivateChangesManager
 from cmk.gui.watolib.automation_commands import AutomationCommand
@@ -70,7 +73,10 @@ def _folder_of_host(h: Host) -> Folder:
                         site_id: make_automation_config(
                             config.sites[site_id],
                         )
-                        for site_id in wato_site_ids(config.sites)
+                        for site_id in [
+                            omd_site(),
+                            *sites_ready_for_remote_automation(config.sites),
+                        ]
                     },
                     debug=config.debug,
                 )

tests/unit/cmk/gui/watolib/test_automatic_host_removal.py

@@ -58,11 +58,6 @@ def default_site_config() -> SiteConfiguration:
     )
 
 
-@pytest.fixture(scope="function", autouse=True)
-def fixture_sitenames(mocker: MockerFixture) -> None:
-    mocker.patch.object(automatic_host_removal, "wato_site_ids", lambda x: ["NO_SITE"])
-
-
 @pytest.fixture(name="activate_changes_mock")
 def fixture_activate_changes(mocker: MockerFixture) -> MagicMock:
     return mocker.patch.object(