Split cmk/gui: Extract quick_setup, eliminate endpoints filegroup

Remove redundant register_config_setups() calls from quick_setup
handlers (already called in registration.py). This breaks the
config_setups > cmk.plugins dependency chain.

Extract quick_setup as //cmk/gui/quick_setup target and move quick_setup
endpoint into endpoints target. Endpoints filegroup eliminated.

CMK-33056

Change-Id: I9159f53dbf141fca604fff66654d82b407f108ba

Author: LarsMichelsen

cmk/BUILD

@@ -490,6 +490,7 @@ py_wheel(
         "//cmk/gui/openapi/spec",
         "//cmk/gui/openapi/spec:utils",
         "//cmk/gui/openapi/spec/spec_generator",
+        "//cmk/gui/quick_setup",
         "//cmk/gui/rest_api_types:notifications",
         "//cmk/gui/rule_specs:compatibility",
         "//cmk/gui/rule_specs:loader",

cmk/gui/BUILD

@@ -1333,8 +1333,8 @@ py_library(
         "//cmk/gui/oauth2_connections:gui_srcs",
         "//cmk/gui/openapi:gui_srcs",
         "//cmk/gui/openapi/api_endpoints:gui_srcs",
-        "//cmk/gui/openapi/endpoints:gui_srcs",
         "//cmk/gui/openapi/spec/spec_generator:gui_srcs",
+        "//cmk/gui/quick_setup:gui_srcs",
         "//cmk/gui/rule_specs:gui_srcs",
         "//cmk/gui/wsgi:gui_srcs",
     ],
@@ -1455,6 +1455,7 @@ py_library(
         "//cmk/gui/openapi/spec",
         "//cmk/gui/openapi/spec:utils",
         "//cmk/gui/openapi/spec/spec_generator",
+        "//cmk/gui/quick_setup",
         "//cmk/gui/rest_api_types:notifications",
         "//cmk/gui/rule_specs:compatibility",
         "//cmk/gui/rule_specs:loader",

cmk/gui/openapi/endpoints/BUILD

@@ -3,13 +3,7 @@ load("@cmk_requirements//:requirements.bzl", "requirement")
 
 py_library(
     name = "endpoints",
-    srcs = glob(
-        include = ["**/*.py"],
-        exclude = [
-            # Blocked: needs cmk.gui.quick_setup (monolithic, needs cmk.plugins)
-            "quick_setup/**/*.py",
-        ],
-    ),
+    srcs = glob(include = ["**/*.py"]),
     imports = ["../../../.."],
     visibility = [
         "//cmk:__subpackages__",
@@ -45,6 +39,7 @@ py_library(
         "//cmk/gui/openapi/restful_objects:type_defs",
         "//cmk/gui/openapi/shared_endpoint_families",
         "//cmk/gui/openapi/spec:utils",
+        "//cmk/gui/quick_setup",
         "//cmk/gui/rest_api_types:notifications",
         "//cmk/gui/userdb",
         "//cmk/gui/utils:agent",
@@ -75,12 +70,3 @@ py_library(
         requirement("werkzeug"),
     ],
 )
-
-# Temporary: endpoint files that still belong to the monolithic //cmk/gui target.
-filegroup(
-    name = "gui_srcs",
-    srcs = glob(include = [
-        "quick_setup/**/*.py",
-    ]),
-    visibility = ["//cmk/gui:__pkg__"],
-)

cmk/gui/quick_setup/BUILD

@@ -0,0 +1,59 @@
+load("@aspect_rules_py//py:defs.bzl", "py_library")
+
+py_library(
+    name = "quick_setup",
+    srcs = ["__init__.py"] + glob(
+        include = [
+            "handlers/**/*.py",
+            "private/**/*.py",
+            "v0_unstable/**/*.py",
+        ],
+    ),
+    imports = ["../../.."],
+    visibility = [
+        "//cmk:__subpackages__",
+        "//tests:__subpackages__",
+    ],
+    deps = [
+        "//cmk/gui:config",
+        "//cmk/gui:default_name",
+        "//cmk/gui:exceptions",
+        "//cmk/gui:http",
+        "//cmk/gui:i18n",
+        "//cmk/gui:log",
+        "//cmk/gui:logged_in",
+        "//cmk/gui:permissions",
+        "//cmk/gui:site_config",
+        "//cmk/gui:user_sites",
+        "//cmk/gui/background_job/job",
+        "//cmk/gui/fields",
+        "//cmk/gui/form_specs",
+        "//cmk/gui/htmllib:html",
+        "//cmk/gui/utils:roles",
+        "//cmk/gui/watolib",
+        "//cmk/gui/watolib:config_infra",
+        "//cmk/gui/watolib:passwords",
+        "//cmk/gui/watolib:registries",
+        "//cmk/utils",
+        "//packages/cmk-ccc:exceptions",
+        "//packages/cmk-ccc:site",
+        "//packages/cmk-ccc:store",
+        "//packages/cmk-ccc:version",
+        "//packages/cmk-plugin-apis:rulesets",
+    ],
+)
+
+# Temporary: quick_setup files that still belong to the monolithic //cmk/gui target.
+filegroup(
+    name = "gui_srcs",
+    srcs = glob(
+        include = ["**/*.py"],
+        exclude = [
+            "__init__.py",
+            "handlers/**/*.py",
+            "private/**/*.py",
+            "v0_unstable/**/*.py",
+        ],
+    ),
+    visibility = ["//cmk/gui:__pkg__"],
+)

cmk/gui/quick_setup/handlers/setup.py

@@ -26,7 +26,6 @@
 from cmk.gui.i18n import _, translate_to_current_language
 from cmk.gui.logged_in import user
 from cmk.gui.permissions import permission_registry
-from cmk.gui.quick_setup.config_setups import register as register_config_setups
 from cmk.gui.quick_setup.handlers.stage import (
     NextStageStructure,
     validate_stage_formspecs,
@@ -412,7 +411,6 @@ def _run_quick_setup_stage(
     ) -> None:
         job_interface.send_progress_update(_("Starting Quick Setup action..."))
 
-        register_config_setups(quick_setup_registry)
         quick_setup = quick_setup_registry[self._quick_setup_id]
         action_result = verify_custom_validators_and_complete_quick_setup(
             quick_setup=quick_setup,

cmk/gui/quick_setup/handlers/stage.py

@@ -35,7 +35,6 @@
 from cmk.gui.i18n import localize
 from cmk.gui.logged_in import user
 from cmk.gui.permissions import permission_registry
-from cmk.gui.quick_setup.config_setups import register as register_config_setups
 from cmk.gui.quick_setup.handlers.utils import (
     Action,
     BackgroundJobException,
@@ -392,7 +391,6 @@ def _run_quick_setup_stage_action(
     ) -> None:
         job_interface.send_progress_update(_("Starting Quick stage action..."))
 
-        register_config_setups(quick_setup_registry)
         quick_setup = quick_setup_registry[self._quick_setup_id]
         built_stages_up_to_index = [
             stage() for stage in quick_setup.stages[: self._stage_index + 1]