agent bakery: introduce feature flag for rulesets

CMK-33533

Change-Id: I2fb9493f814e56185b1ef42ceb6a1052f8ed9998

Author: gavinmcguigan

cmk/gui/common_registration.py

@@ -166,6 +166,7 @@ def register(
     help_about_checkmk_entries: Callable[[], list[NavItemTopicEntry]],
     token_authenticated_page_registry: TokenAuthenticatedPageRegistry,
     builtin_pagetype_topic_registry: pagetypes.BuiltinPagetypeTopicRegistry,
+    agent_bakery_enabled: bool,
 ) -> None:
     hooks.register_thread_cache_cleanup()
     notification_parameter_registry.register_form_spec_plugin = register_plugin
@@ -352,7 +353,12 @@ def register(
     user_config.register(config_file_registry)
     configuration_bundle_store.register(config_file_registry)
     deprecations.register(cron_job_registry)
-    rulespec.register(edition, rulespec_registry, notification_parameter_registry)
+    rulespec.register(
+        edition,
+        rulespec_registry,
+        notification_parameter_registry,
+        agent_bakery_enabled,
+    )
     welcome.register(page_registry, snapin_registry)
     search_registration.register(
         edition,

cmk/gui/community_registration.py

@@ -131,7 +131,7 @@ def register_painters() -> None:
     painter_registry.register(graph.PainterHostPnpgraph)
 
 
-def register(edition: Edition) -> None:
+def register(edition: Edition, agent_bakery_enabled: bool) -> None:
     sample_config_generator_registry.register(SampleConfigGeneratorGroups)
     network_scan.register(host_attribute_registry, automation_command_registry, cron_job_registry)
     nagvis.register(permission_section_registry, permission_registry, snapin_registry)
@@ -191,6 +191,7 @@ def register(edition: Edition) -> None:
         default_about_checkmk_entries,
         token_authenticated_page_registry,
         builtin_pagetype_topic_registry,
+        agent_bakery_enabled,
     )
 
     ldap_registration(

cmk/gui/main_modules.py

@@ -7,6 +7,10 @@
 
 from cmk.ccc.version import Edition
 from cmk.gui.legacy_plugins import get_failed_plugins as get_failed_plugins
+from cmk.licensing.community_handler import (  # astrein: disable=cmk-module-layer-violation
+    CommunityLicensingHandler,
+)
+from cmk.licensing.features import licensed_features  # astrein: disable=cmk-module-layer-violation
 
 _registered_edition: Edition | None = None
 
@@ -22,31 +26,51 @@ def register(edition: Edition) -> None:
         return
     _registered_edition = edition
 
+    # NOTE: CommunityLicensingHandler is used here because the edition-specific handler has not
+    # been registered yet at this point in the call chain. This is safe because licensed_features()
+    # currently ignores the handler entirely (see features.py) and derives bakery availability
+    # solely from the edition. Once licensed_features() is simplified to reflect this, the
+    # handler argument will be removed and this workaround will no longer be needed.
+    agent_bakery_enabled = licensed_features(
+        edition, CommunityLicensingHandler.make()
+    ).bakery.enabled
+
     match edition:
         case Edition.PRO:
             import cmk.gui.nonfree.pro.registration  # type: ignore[import-not-found, import-untyped, unused-ignore]
 
-            cmk.gui.nonfree.pro.registration.register(edition)
+            cmk.gui.nonfree.pro.registration.register(
+                edition,
+                agent_bakery_enabled=agent_bakery_enabled,
+            )
 
         case Edition.ULTIMATEMT:
             import cmk.gui.nonfree.ultimatemt.registration  # type: ignore[import-not-found, import-untyped, unused-ignore]
 
-            cmk.gui.nonfree.ultimatemt.registration.register(edition)
+            cmk.gui.nonfree.ultimatemt.registration.register(
+                edition, agent_bakery_enabled=agent_bakery_enabled
+            )
 
         case Edition.ULTIMATE:
             import cmk.gui.nonfree.ultimate.registration  # type: ignore[import-not-found, import-untyped, unused-ignore]
 
-            cmk.gui.nonfree.ultimate.registration.register(edition)
+            cmk.gui.nonfree.ultimate.registration.register(
+                edition, agent_bakery_enabled=agent_bakery_enabled
+            )
 
         case Edition.CLOUD:
             import cmk.gui.nonfree.cloud.registration  # type: ignore[import-not-found, import-untyped, unused-ignore]
 
-            cmk.gui.nonfree.cloud.registration.register(edition)
+            cmk.gui.nonfree.cloud.registration.register(
+                edition, agent_bakery_enabled=agent_bakery_enabled
+            )
 
         case Edition.COMMUNITY:
             import cmk.gui.community_registration
 
-            cmk.gui.community_registration.register(edition)
+            cmk.gui.community_registration.register(
+                edition, agent_bakery_enabled=agent_bakery_enabled
+            )
 
         case _ as unreachable:
             assert_never(unreachable)

cmk/gui/rule_specs/loader.py

@@ -61,14 +61,15 @@ def _discover_modules_from(*names: str) -> set[str]:
 def load_api_v1_rule_specs(
     raise_errors: bool,
     edition: Edition,
+    agent_bakery_enabled: bool,
 ) -> tuple[Sequence[Exception], Sequence[LoadedRuleSpec]]:
     used_entry_points = (
         {
             type_: prefix
             for type_, prefix in entry_point_prefixes().items()
             if type_ is not AgentConfig
         }
-        if edition is Edition.COMMUNITY
+        if not agent_bakery_enabled
         else entry_point_prefixes()
     )
 

cmk/gui/rulespec.py

@@ -20,10 +20,12 @@ def register(
     edition: Edition,
     rulespec_registry: RulespecRegistry,
     notification_parameter_registry: NotificationParameterRegistry,
+    agent_bakery_enabled: bool,
 ) -> None:
     errors, loaded_rule_specs = load_api_v1_rule_specs(
         raise_errors=debug_enabled(),
         edition=edition,
+        agent_bakery_enabled=agent_bakery_enabled,
     )
     if errors:
         logger.error("Error loading rulespecs: %s", errors)