Activate changes: whichSites should be an array of sites affected

Change-Id: Ief9191c44f8e12904392bb0a323865afe08ea9f0

Author: gavinmcguigan

cmk/gui/watolib/activate_changes.py

@@ -1087,7 +1087,7 @@ class PendingChangesSummary(TypedDict):
     changeText: str
     user: str
     time: float
-    whichSites: str
+    whichSites: list[str]
 
 
 class ActivationChangesSummary(TypedDict):
@@ -1369,9 +1369,9 @@ def _get_site_version(site_id: SiteId) -> str:
                     changeText=unescape(change["text"]),
                     user=change["user_id"],
                     time=change["time"],
-                    whichSites="All sites"
+                    whichSites=["All sites"]
                     if affects_all_sites(list(activation_sites(sites)), change)
-                    else ", ".join(sorted(change["affected_sites"])),
+                    else change["affected_sites"],
                 )
                 for _, change in changes_that_require_activation
             ],

packages/cmk-frontend-vue/src/main-menu/ChangesApp.vue

@@ -579,7 +579,8 @@ onMounted(() => {
                 <CmkZebra :num="idx">
                   <CmkIndent
                     v-if="
-                      change.whichSites === 'All sites' || selectedSites.includes(change.whichSites)
+                      change.whichSites.includes('All sites') ||
+                      change.whichSites.some((site) => selectedSites.includes(site))
                     "
                     class="cmk-indent-pending-change-container"
                     :class="{ 'red-text': change.user !== user_name && change.user !== null }"
@@ -593,7 +594,7 @@ onMounted(() => {
                       <div class="cmk-div-user-sites-timestamp">
                         <span>{{ change.user }}</span>
                         <span>|</span>
-                        <span>{{ change.whichSites }}</span>
+                        <span>{{ change.whichSites.join(', ') }}</span>
                       </div>
                       <span>{{ change.timestring }}</span>
                     </div>

packages/cmk-frontend-vue/src/main-menu/ChangesInterfaces.ts

@@ -60,7 +60,7 @@ export interface PendingChanges {
   changeText: string
   user: string
   time: number
-  whichSites: string
+  whichSites: Array<string>
   timestring?: string
 }