Skip to content

Commit 33afd92

Browse files
committed
Pull up automation config further #19
Change-Id: I750cc84b912109bd31900b7fbf3affac8d11ee37
1 parent 2443a9b commit 33afd92

3 files changed

Lines changed: 35 additions & 12 deletions

File tree

cmk/gui/wato/pages/folders.py

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@
7777
)
7878
from cmk.gui.watolib.agent_registration import remove_tls_registration
7979
from cmk.gui.watolib.audit_log_url import make_object_audit_log_url
80+
from cmk.gui.watolib.automations import make_automation_config
8081
from cmk.gui.watolib.check_mk_automations import delete_hosts
8182
from cmk.gui.watolib.configuration_bundle_store import is_locked_by_quick_setup
8283
from cmk.gui.watolib.groups_io import load_contact_group_information
@@ -637,7 +638,12 @@ def action(self) -> ActionResult:
637638
if isinstance(self._folder, SearchFolder):
638639
raise MKUserError(None, _("This action can not be performed on search results"))
639640
remove_tls_registration(
640-
self._folder.get_hosts_by_site(list(self._folder.hosts())),
641+
[
642+
(make_automation_config(active_config.sites[site_id]), hosts)
643+
for site_id, hosts in self._folder.get_hosts_by_site(
644+
list(self._folder.hosts())
645+
).items()
646+
],
641647
debug=active_config.debug,
642648
)
643649
return None
@@ -722,7 +728,13 @@ def action(self) -> ActionResult:
722728
if isinstance(self._folder, SearchFolder):
723729
raise MKUserError(None, _("This action can not be performed on search results"))
724730
remove_tls_registration(
725-
self._folder.get_hosts_by_site(selected_host_names), debug=active_config.debug
731+
[
732+
(make_automation_config(active_config.sites[site_id]), hosts)
733+
for site_id, hosts in self._folder.get_hosts_by_site(
734+
selected_host_names
735+
).items()
736+
],
737+
debug=active_config.debug,
726738
)
727739

728740
return None

cmk/gui/wato/pages/hosts.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,13 @@ def action(self) -> ActionResult:
516516

517517
if request.var("_remove_tls_registration"):
518518
remove_tls_registration(
519-
{self._host.site_id(): [self._host.name()]}, debug=active_config.debug
519+
[
520+
(
521+
make_automation_config(active_config.sites[self._host.site_id()]),
522+
[self._host.name()],
523+
)
524+
],
525+
debug=active_config.debug,
520526
)
521527
return None
522528

cmk/gui/watolib/agent_registration.py

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,35 +4,40 @@
44
# conditions defined in the file COPYING, which is part of this source code package.
55

66
import json
7-
from collections.abc import Mapping, Sequence
7+
from collections.abc import Sequence
88

99
from cmk.ccc.exceptions import MKGeneralException
1010
from cmk.ccc.hostaddress import HostName
11-
from cmk.ccc.site import SiteId
1211

1312
from cmk.utils.agent_registration import get_uuid_link_manager
1413

15-
from cmk.gui.config import active_config
1614
from cmk.gui.http import request
1715
from cmk.gui.log import logger
18-
from cmk.gui.site_config import site_is_local
1916
from cmk.gui.watolib.automation_commands import AutomationCommand
20-
from cmk.gui.watolib.automations import do_remote_automation, RemoteAutomationConfig
17+
from cmk.gui.watolib.automations import (
18+
do_remote_automation,
19+
LocalAutomationConfig,
20+
RemoteAutomationConfig,
21+
)
2122

2223

2324
def remove_tls_registration(
24-
hosts_by_site: Mapping[SiteId, Sequence[HostName]], *, debug: bool
25+
hosts_by_site: Sequence[
26+
tuple[LocalAutomationConfig | RemoteAutomationConfig, Sequence[HostName]]
27+
],
28+
*,
29+
debug: bool,
2530
) -> None:
26-
for site_id, host_names in hosts_by_site.items():
31+
for automation_config, host_names in hosts_by_site:
2732
if not host_names:
2833
continue
2934

30-
if site_is_local(site_config := active_config.sites[site_id], site_id):
35+
if isinstance(automation_config, LocalAutomationConfig):
3136
_remove_tls_registration(host_names)
3237
continue
3338

3439
do_remote_automation(
35-
RemoteAutomationConfig.from_site_config(site_config),
40+
automation_config,
3641
"remove-tls-registration",
3742
[("host_names", json.dumps(host_names))],
3843
debug=debug,

0 commit comments

Comments
 (0)