Skip to content

Commit 50f81a6

Browse files
Deploy cmk to site-packages
CMK-33645 Change-Id: Id3d946b27ea82c531e71370f20edd81e81d3f676
1 parent 4419791 commit 50f81a6

6 files changed

Lines changed: 16 additions & 7 deletions

File tree

cmk/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -571,7 +571,6 @@ build_test(
571571

572572
package_wheel(
573573
name = "cmk_tar",
574-
prefix = "lib/python3",
575574
visibility = ["//visibility:public"],
576575
whl = "whl",
577576
)

omd/packages/check_mk/skel/etc/check_mk/apache.conf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,10 @@ WSGIRestrictSignal Off
5454
# Initialize the Checkmk application when starting a new apache process with a
5555
# new interpreter to prevent initializations during handling of the first HTTP
5656
# request
57-
WSGIImportScript ###ROOT###/lib/python3/cmk/gui/wsgi/wsgi_import.py process-group=%{GLOBAL} application-group=%{GLOBAL}
57+
WSGIImportScript ###ROOT###/lib/python###PYTHON_MAJOR_MINOR###/site-packages/cmk/gui/wsgi/wsgi_import.py process-group=%{GLOBAL} application-group=%{GLOBAL}
5858

59-
AliasMatch ^/###SITE###/check_mk/($|api/.*|[a-z_-]+\.py) ###ROOT###/lib/python3/cmk/gui/wsgi/applications/index.wsgi
60-
<Directory ###ROOT###/lib/python3/cmk/gui/wsgi/applications>
59+
AliasMatch ^/###SITE###/check_mk/($|api/.*|[a-z_-]+\.py) ###ROOT###/lib/python###PYTHON_MAJOR_MINOR###/site-packages/cmk/gui/wsgi/applications/index.wsgi
60+
<Directory ###ROOT###/lib/python###PYTHON_MAJOR_MINOR###/site-packages/cmk/gui/wsgi/applications>
6161
SetHandler wsgi-script
6262
Options +ExecCGI
6363

omd/packages/omd/omdlib/contexts.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66

77
import os
8+
import sys
89
from pathlib import Path
910

1011
from omdlib.init_scripts import check_status
@@ -61,6 +62,7 @@ def replacements(self) -> Replacements:
6162
"###SITE###": self.name,
6263
"###ROOT###": self._paths.home,
6364
"###EDITION###": version.split(".")[-1],
65+
"###PYTHON_MAJOR_MINOR###": f"{sys.version_info.major}.{sys.version_info.minor}",
6466
}
6567

6668
def set_config(self, config: Config) -> None:

omd/packages/omd/omdlib/main.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -408,6 +408,7 @@ def patch_skeleton_files(
408408
"###SITE###": old_site_name,
409409
"###ROOT###": SitePaths.from_site_name(old_site_name).home,
410410
"###EDITION###": new_replacements["###EDITION###"],
411+
"###PYTHON_MAJOR_MINOR###": new_replacements["###PYTHON_MAJOR_MINOR###"],
411412
}
412413
skelroot = "/omd/versions/%s/skel" % omdlib.__version__
413414
with contextlib.chdir(skelroot): # make relative paths
@@ -925,19 +926,22 @@ def update_file(
925926
new_skel = "/omd/versions/%s/skel" % new_version
926927

927928
site_home = SitePaths.from_site_name(site.name).home
929+
python_major_minor = f"{sys.version_info.major}.{sys.version_info.minor}"
928930
new_replacements = {
929931
"###SITE###": site.name,
930932
"###ROOT###": site_home,
931933
# When calling this during "omd update", the site.version and site.edition still point to
932934
# the original edition, because we are still in the update prcedure and the version symlink
933935
# has not been changed yet.
934936
"###EDITION###": new_edition,
937+
"###PYTHON_MAJOR_MINOR###": python_major_minor,
935938
}
936939

937940
old_replacements = {
938941
"###SITE###": site.name,
939942
"###ROOT###": site_home,
940943
"###EDITION###": old_edition,
944+
"###PYTHON_MAJOR_MINOR###": python_major_minor,
941945
}
942946

943947
old_path = old_skel + "/" + relpath

tests/integration/omd/test_python.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,8 +210,8 @@ def test_python_optimized_and_lto_enable(site: Site) -> None:
210210
[
211211
pytest.param(
212212
"cmk.base.config",
213-
f"lib/python{PYVER.major}/cmk/base/config.py",
214-
f"lib/python{PYVER.major}/cmk/base/__pycache__/config.cpython-{PYVER.major}{PYVER.minor}.pyc",
213+
f"lib/python{PYVER.major}.{PYVER.minor}/site-packages/cmk/base/config.py",
214+
f"lib/python{PYVER.major}.{PYVER.minor}/site-packages/cmk/base/__pycache__/config.cpython-{PYVER.major}{PYVER.minor}.pyc",
215215
id="pyc for imports from the big monolith cmk namespace",
216216
),
217217
pytest.param(

tests/unit/omdlib/test_site_context.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66

77
import os
8+
import sys
89

910
import pytest
1011

@@ -27,4 +28,7 @@ def test_site_context_replacements(monkeypatch: pytest.MonkeyPatch) -> None:
2728
assert replacements["###SITE###"] == "dingeling"
2829
assert replacements["###ROOT###"] == "/omd/sites/dingeling"
2930
assert replacements["###EDITION###"] == "pro"
30-
assert len(replacements) == 3
31+
assert (
32+
replacements["###PYTHON_MAJOR_MINOR###"]
33+
== f"{sys.version_info.major}.{sys.version_info.minor}"
34+
)

0 commit comments

Comments
 (0)