Skip to content

Commit 63981d0

Browse files
smeagol91smeagol91
committed
Backport UI - Dashboards component to the 2.5.0 branch
* Create dedicated "UI - Dashboards" component (ui_dashboards) * Move OWNERS files from api sub directories up to dashboard level * Point dashboard OWNERS files to ui_dashboards instead of ui_monitoring Change-Id: I96c179f34ef861d06312e915135b00260fc21f72
1 parent f408dfa commit 63981d0

4 files changed

Lines changed: 23 additions & 2 deletions

File tree

cmk/gui/dashboard/api/OWNERS renamed to cmk/gui/dashboard/OWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
set noparent # don't inherit owners information from parent folders
22

3-
file:/component_owners/ui_monitoring/OWNERS_DEFINITION
3+
file:/component_owners/ui_dashboards/OWNERS_DEFINITION
44

55
# Please
66
# - don't add individual owners here but provide a reference to an OWNERS_DEFINITION file instead

‎component_owners/ui_dashboards/OWNERS_DEFINITION‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
sebastian.groemcke@checkmk.com # component lead
2+
3+
wontek.hong@checkmk.com
4+
kenneth.okoh@checkmk.com
5+
leonardo.petrora@checkmk.com
6+
christopher.krause@checkmk.com
7+
8+
# Find information about code-owners (+ find-owners syntax) here:
9+
# - https://android-review.googlesource.com/plugins/code-owners/Documentation/backend-find-owners-cookbook.html
10+
# - https://android-review.googlesource.com/plugins/code-owners/Documentation/backend-find-owners.html#syntax

‎packages/cmk-frontend-vue/src/dashboard/OWNERS‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
set noparent # don't inherit owners information from parent folders
22

3-
file:/component_owners/ui_monitoring/OWNERS_DEFINITION
3+
file:/component_owners/ui_dashboards/OWNERS_DEFINITION
44

55
# Please
66
# - don't add individual owners here but provide a reference to an OWNERS_DEFINITION file instead

‎packages/cmk-frontend-vue/tests/dashboard/OWNERS‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
set noparent # don't inherit owners information from parent folders
2+
3+
file:/component_owners/ui_dashboards/OWNERS_DEFINITION
4+
5+
# Please
6+
# - don't add individual owners here but provide a reference to an OWNERS_DEFINITION file instead
7+
# - consider a `per-file <PATH>=set noparent` line for each `per-file` rule
8+
#
9+
# Find information about code-owners (+ find-owners syntax) here:
10+
# - https://android-review.googlesource.com/plugins/code-owners/Documentation/backend-find-owners-cookbook.html
11+
# - https://android-review.googlesource.com/plugins/code-owners/Documentation/backend-find-owners.html#syntax

0 commit comments

Comments
 (0)