Skip to content

Commit 6d0dcf4

Browse files
Revert "OTel: resolve the custom service ruleset per host"
Revert submission 149558 Reason for revert: https://tribe29.slack.com/archives/C085MHGLPJ6/p1786458273376609 Reverted changes: /q/submissionid:149558 Change-Id: I5c34577059a7752dd135e36bfd067bbd885189fd
1 parent 0831be9 commit 6d0dcf4

9 files changed

Lines changed: 3 additions & 117 deletions

File tree

cmk/base/config/_impl.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,7 @@
3838
from cmk.base.configlib.agent import make_only_from_config
3939
from cmk.base.configlib.checkengine import CheckingConfig
4040
from cmk.base.configlib.exit_code import make_exit_code_spec
41-
from cmk.base.configlib.fetchers import (
42-
make_tcp_fetcher_config,
43-
make_telemetry_custom_service_config,
44-
)
41+
from cmk.base.configlib.fetchers import make_tcp_fetcher_config
4542
from cmk.base.configlib.inventory import make_inventory_config
4643
from cmk.base.configlib.labels import LabelConfig
4744
from cmk.base.configlib.loaded_config import BaseConfig, CustomCheck
@@ -1452,9 +1449,6 @@ def make_source_config(
14521449
tcp_fetcher_config=make_tcp_fetcher_config(
14531450
self._loaded_config, self.ruleset_matcher, self.label_manager.labels_of_host
14541451
),
1455-
telemetry_custom_service=make_telemetry_custom_service_config(
1456-
self._loaded_config, self.ruleset_matcher, self.label_manager.labels_of_host
1457-
),
14581452
is_cmc=self._loaded_config.monitoring_core == "cmc",
14591453
uuid_lookup_dir=cmk.utils.paths.uuid_lookup_dir,
14601454
)

cmk/base/configlib/fetchers.py

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
# conditions defined in the file COPYING, which is part of this source code package.
55

66

7-
from collections.abc import Callable, Mapping, Sequence
7+
from collections.abc import Callable, Mapping
88

99
from cmk.base.configlib.loaded_config import BaseConfig
1010
from cmk.ccc.hostaddress import HostName
@@ -51,23 +51,6 @@ def make_tcp_fetcher_config(
5151
)
5252

5353

54-
def make_telemetry_custom_service_config(
55-
loaded_config: BaseConfig,
56-
ruleset_matcher: RulesetMatcher,
57-
labels_of_host: Callable[[HostName], Labels],
58-
) -> Callable[[HostName], Sequence[Mapping[str, object]]]:
59-
"""Resolve the custom telemetry service ruleset for a single host.
60-
61-
The ruleset's eval type is ALL, so every matching rule contributes; the caller
62-
gets them in rule order.
63-
"""
64-
return SingleHostRulesetMatcher(
65-
host_ruleset=loaded_config.telemetry_custom_service,
66-
matcher=ruleset_matcher,
67-
labels_of_host=labels_of_host,
68-
)
69-
70-
7154
def make_parsed_snmp_fetch_intervals_config(
7255
loaded_config: BaseConfig,
7356
ruleset_matcher: RulesetMatcher,

cmk/base/configlib/loaded_config.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ class BaseConfig: # type: ignore[explicit-any]
107107
piggyback_max_cachefile_age: int
108108
agent_encryption: Sequence[RuleSpec[str | None]]
109109
agent_exclude_sections: Sequence[RuleSpec[dict[str, str]]]
110-
telemetry_custom_service: Sequence[RuleSpec[Mapping[str, object]]]
111110
cmc_real_time_checks: RealTimeChecks | None
112111
snmp_check_interval: list[
113112
RuleSpec[

cmk/base/default_config/base.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
agent_encryption: list[RuleSpec[str | None]] = []
4747
encryption_handling: list[RuleSpec[Mapping[str, str]]] = []
4848
agent_exclude_sections: list[RuleSpec[dict[str, str]]] = []
49-
telemetry_custom_service: list[RuleSpec[Mapping[str, object]]] = []
5049
# UDP ports used for SNMP
5150
snmp_ports: list[RuleSpec[int]] = []
5251
tcp_connect_timeout = 5.0

packages/cmk-check-engine/cmk/checkengine/source_abc/_config.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ def __init__(
4444
program_commandline: Callable[[HostName, _AddressFamily, HostAddress | None, str], str],
4545
snmp_fetcher_config: SNMPFetcherConfig,
4646
tcp_fetcher_config: TCPFetcherConfig,
47-
telemetry_custom_service: Callable[[HostName], Sequence[Mapping[str, object]]],
4847
is_cmc: bool,
4948
uuid_lookup_dir: Path,
5049
) -> None:
@@ -57,7 +56,6 @@ def __init__(
5756
self._management_credentials: Final = management_credentials
5857
self.snmp_fetcher_config: Final = snmp_fetcher_config
5958
self.tcp_fetcher_config: Final = tcp_fetcher_config
60-
self.telemetry_custom_service: Final = telemetry_custom_service
6159
self.is_cmc: Final = is_cmc
6260
self.uuid_lookup_dir: Final = uuid_lookup_dir
6361

packages/cmk-check-engine/cmk/checkengine/source_abc/_optional.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from __future__ import annotations
77

88
import abc
9-
from collections.abc import Callable, Mapping, Sequence, Sized
9+
from collections.abc import Sized
1010
from dataclasses import dataclass
1111
from pathlib import Path
1212
from typing import Self
@@ -36,7 +36,6 @@ class SourceContext:
3636
omd_root: Path
3737
metrics_association: str | None
3838
check_mk_check_interval: float
39-
telemetry_custom_service: Callable[[HostName], Sequence[Mapping[str, object]]]
4039

4140

4241
class OptionalSource[TRawData: Sized](Source[TRawData], abc.ABC):

packages/cmk-check-engine/cmk/checkengine/source_builder.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@ def __init__(
120120
omd_root=self.omd_root,
121121
metrics_association=self._metrics_association,
122122
check_mk_check_interval=self.check_mk_check_interval,
123-
telemetry_custom_service=source_config.telemetry_custom_service,
124123
)
125124
)
126125

tests/testlib/common/empty_config.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
piggyback_max_cachefile_age=3600,
4040
agent_encryption=(),
4141
agent_exclude_sections=(),
42-
telemetry_custom_service=(),
4342
cmc_real_time_checks=None,
4443
snmp_check_interval=[],
4544
agent_bakery_logging=None,

tests/unit/cmk/base/configlib/test_fetchers.py

Lines changed: 0 additions & 84 deletions
This file was deleted.

0 commit comments

Comments
 (0)