Skip to content

Commit 977eb25

Browse files
18233 gui(bi): fix bulk delete/move actions
Using `RequireConfirmation` here is problematic as it uses the `preventDefault` function in JavaScript. Therefore, the action is completely ignored. Removing this drops the dialog pop-up for bulk move, but is consistent with how we perform bulk move on the Hosts page. SUP-23039 Co-authored-by: Benjamin Knapp <benjamin.knapp@checkmk.com> Change-Id: I8d724d59b2ae66dd436446aec94c3662115a1c36
1 parent 0fcb6e8 commit 977eb25

2 files changed

Lines changed: 16 additions & 4 deletions

File tree

.werks/18233.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
[//]: # (werk v2)
2+
# BI: fix bulk delete/move aggregations actions
3+
4+
key | value
5+
---------- | ---
6+
date | 2025-07-04T09:40:46+00:00
7+
version | 2.4.0p7
8+
class | fix
9+
edition | cre
10+
component | bi
11+
level | 1
12+
compatible | yes
13+
14+
This werk fixes a regression that was introduced in versions >=v2.3.0 where
15+
users were unable to perform bulk delete/move aggregations. These actions are
16+
now properly supported.

cmk/gui/bi/_config.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
from cmk.gui.htmllib.foldable_container import foldable_container
2828
from cmk.gui.htmllib.generator import HTMLWriter
2929
from cmk.gui.htmllib.html import html
30-
from cmk.gui.htmllib.type_defs import RequireConfirmation
3130
from cmk.gui.http import request
3231
from cmk.gui.i18n import _, _l, ungettext
3332
from cmk.gui.logged_in import user
@@ -2203,9 +2202,6 @@ def page(self) -> None:
22032202
with html.form_context(
22042203
"bulk_action_form",
22052204
method="POST",
2206-
require_confirmation=RequireConfirmation(
2207-
html=_("Do you really want to move the selected aggregations?")
2208-
),
22092205
):
22102206
self._render_aggregations()
22112207
html.hidden_field("selection_id", weblib.selection_id())

0 commit comments

Comments
 (0)