Skip to content

Commit 9bbfe85

Browse files
innovaphone(mem): rename new type to utilization
Change-Id: I49ea6b14b8100ca5fc86e63fc3aace49b691ca1c
1 parent 0c32b9f commit 9bbfe85

2 files changed

Lines changed: 12 additions & 12 deletions

File tree

cmk/plugins/innovaphone/agent_based/innovaphone_mem.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,26 +17,26 @@
1717
)
1818
from cmk.rulesets.v1.form_specs import SimpleLevelsConfigModel
1919

20-
MemoryUsedPercent = NewType("MemoryUsedPercent", int)
20+
Utilization = NewType("Utilization", int)
2121

2222

23-
def parse_innovaphone_mem(string_table: StringTable) -> MemoryUsedPercent | None:
23+
def parse_innovaphone_mem(string_table: StringTable) -> Utilization | None:
2424
match string_table:
2525
case [[_, str(value)]] if value.isdigit():
26-
return MemoryUsedPercent(int(value))
26+
return Utilization(int(value))
2727
case _:
2828
return None
2929

3030

31-
def discover_innovaphone_mem(section: MemoryUsedPercent) -> DiscoveryResult:
31+
def discover_innovaphone_mem(section: Utilization) -> DiscoveryResult:
3232
yield Service()
3333

3434

3535
class CheckParams(TypedDict):
3636
levels: SimpleLevelsConfigModel[float]
3737

3838

39-
def check_innovaphone_mem(params: CheckParams, section: MemoryUsedPercent) -> CheckResult:
39+
def check_innovaphone_mem(params: CheckParams, section: Utilization) -> CheckResult:
4040
yield from check_levels(
4141
section,
4242
label="Current",

tests/unit/cmk/plugins/innovaphone/agent_based/test_innovaphone_mem.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
check_innovaphone_mem,
1111
CheckParams,
1212
discover_innovaphone_mem,
13-
MemoryUsedPercent,
1413
parse_innovaphone_mem,
14+
Utilization,
1515
)
1616

1717

@@ -28,11 +28,11 @@ def test_parse_innovaphone_mem_empty_data(string_table: StringTable) -> None:
2828

2929

3030
def test_parse_innovaphone_mem_success() -> None:
31-
assert parse_innovaphone_mem([["MEM", "55"]]) == MemoryUsedPercent(55)
31+
assert parse_innovaphone_mem([["MEM", "55"]]) == Utilization(55)
3232

3333

3434
def test_discover_innovaphone_mem() -> None:
35-
section = MemoryUsedPercent(55)
35+
section = Utilization(55)
3636
assert list(discover_innovaphone_mem(section)) == [Service()]
3737

3838

@@ -41,7 +41,7 @@ def test_discover_innovaphone_mem() -> None:
4141
[
4242
pytest.param(
4343
{"levels": ("fixed", (60.0, 70.0))},
44-
MemoryUsedPercent(55),
44+
Utilization(55),
4545
[
4646
Result(state=State.OK, summary="Current: 55.00%"),
4747
Metric("mem_used_percent", 55.0, levels=(60.0, 70.0)),
@@ -50,7 +50,7 @@ def test_discover_innovaphone_mem() -> None:
5050
),
5151
pytest.param(
5252
{"levels": ("fixed", (60.0, 70.0))},
53-
MemoryUsedPercent(65),
53+
Utilization(65),
5454
[
5555
Result(state=State.WARN, summary="Current: 65.00% (warn/crit at 60.00%/70.00%)"),
5656
Metric("mem_used_percent", 65.0, levels=(60.0, 70.0)),
@@ -59,7 +59,7 @@ def test_discover_innovaphone_mem() -> None:
5959
),
6060
pytest.param(
6161
{"levels": ("fixed", (60.0, 70.0))},
62-
MemoryUsedPercent(85),
62+
Utilization(85),
6363
[
6464
Result(state=State.CRIT, summary="Current: 85.00% (warn/crit at 60.00%/70.00%)"),
6565
Metric("mem_used_percent", 85.0, levels=(60.0, 70.0)),
@@ -70,7 +70,7 @@ def test_discover_innovaphone_mem() -> None:
7070
)
7171
def test_check_innovaphone_mem(
7272
params: CheckParams,
73-
section: MemoryUsedPercent,
73+
section: Utilization,
7474
expected: list[Result | Metric],
7575
) -> None:
7676
assert list(check_innovaphone_mem(params, section)) == expected

0 commit comments

Comments
 (0)