user_roles: switch to new framework, remove old

Change-Id: I61ebf7a4e3edbd44da2abf0135c81a22152d2f74

Author: gavinmcguigan

cmk/gui/fields/definitions.py

@@ -35,7 +35,6 @@
 from cmk.gui.fields.utils import edition_field_description, tree_to_expr
 from cmk.gui.groups import GroupName, GroupType
 from cmk.gui.logged_in import user
-from cmk.gui.permissions import permission_registry
 from cmk.gui.userdb import load_users
 from cmk.gui.watolib import userroles
 from cmk.gui.watolib.groups_io import load_group_information
@@ -1437,32 +1436,6 @@ def _validate(self, value: str) -> None:
                 raise self.make_error("should_be_custom", role=value)
 
 
-class PermissionField(base.String):
-    default_error_messages = {
-        "invalid_permission": "The specified permission name doesn't exist: {value!r}",
-    }
-
-    def __init__(
-        self,
-        required: bool = True,
-        validate: Callable[[object], bool] | Collection[Callable[[object], bool]] | None = None,
-        **kwargs: Any,
-    ) -> None:
-        super().__init__(
-            example="general.edit_profile",
-            description="The name of a permission",
-            required=required,
-            validate=validate,
-            **kwargs,
-        )
-
-    @override
-    def _validate(self, value: str) -> None:
-        super()._validate(value)
-        if value not in permission_registry:
-            raise self.make_error("invalid_permission", value=value)
-
-
 class Username(base.String):
     default_error_messages = {
         "should_exist": "Username missing: {username!r}",
@@ -1620,7 +1593,6 @@ def _serialize(self, value: str | Folder, attr: str | None, obj: object, **kwarg
     "PasswordEditableBy",
     "PasswordIdent",
     "PasswordShare",
-    "PermissionField",
     "PythonString",
     "query_field",
     "SiteField",

cmk/gui/openapi/api_endpoints/user_role/create_user_role.py

@@ -50,5 +50,5 @@ def create_user_role_v1(body: CreateUserRoleModel) -> UserRoleModel:
     ),
     permissions=EndpointPermissions(required=RW_PERMISSIONS),
     doc=EndpointDoc(family=USER_ROLE_FAMILY.name),
-    versions={APIVersion.UNSTABLE: EndpointHandler(handler=create_user_role_v1)},
+    versions={APIVersion.V1: EndpointHandler(handler=create_user_role_v1)},
 )

cmk/gui/openapi/api_endpoints/user_role/delete_user_role.py

@@ -48,5 +48,5 @@ def delete_user_role_v1(
     ),
     permissions=EndpointPermissions(required=RW_PERMISSIONS),
     doc=EndpointDoc(family=USER_ROLE_FAMILY.name),
-    versions={APIVersion.UNSTABLE: EndpointHandler(handler=delete_user_role_v1)},
+    versions={APIVersion.V1: EndpointHandler(handler=delete_user_role_v1)},
 )

cmk/gui/openapi/api_endpoints/user_role/edit_user_role.py

@@ -111,5 +111,5 @@ def edit_user_role_v1(
     ),
     permissions=EndpointPermissions(required=RW_PERMISSIONS),
     doc=EndpointDoc(family=USER_ROLE_FAMILY.name),
-    versions={APIVersion.UNSTABLE: EndpointHandler(handler=edit_user_role_v1)},
+    versions={APIVersion.V1: EndpointHandler(handler=edit_user_role_v1)},
 )

cmk/gui/openapi/api_endpoints/user_role/list_user_roles.py

@@ -60,5 +60,5 @@ def list_user_roles_v1() -> UserRoleCollectionModel:
     ),
     permissions=EndpointPermissions(required=PERMISSIONS),
     doc=EndpointDoc(family=USER_ROLE_FAMILY.name),
-    versions={APIVersion.UNSTABLE: EndpointHandler(handler=list_user_roles_v1)},
+    versions={APIVersion.V1: EndpointHandler(handler=list_user_roles_v1)},
 )

cmk/gui/openapi/api_endpoints/user_role/show_user_role.py

@@ -45,5 +45,5 @@ def show_user_role_v1(
     ),
     permissions=EndpointPermissions(required=PERMISSIONS),
     doc=EndpointDoc(family=USER_ROLE_FAMILY.name),
-    versions={APIVersion.UNSTABLE: EndpointHandler(handler=show_user_role_v1)},
+    versions={APIVersion.V1: EndpointHandler(handler=show_user_role_v1)},
 )