Skip to content

Commit c33a1ab

Browse files
committed
Consolidate core toolkit GUI test targets
Fold the tests/unit/cmk/gui/{htmllib,theme,utils,valuespecs, user_message} py_cmk_test targets into the existing root :tests suite. Test semantics unchanged: 1507 passed + 2 skipped before and after. mypy actions: 6 -> 1 .py files parsed by mypy, summed over actions: 13,681 -> 2,787 (-80%). CMK-34924 Change-Id: Ic9d99e864043066658e844b87b9cc38a72c131f1
1 parent 183c21d commit c33a1ab

6 files changed

Lines changed: 14 additions & 110 deletions

File tree

tests/unit/cmk/gui/BUILD

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,9 +450,19 @@ py_cmk_test(
450450
],
451451
)
452452

453+
# Core toolkit test suite: the root-level tests plus htmllib, theme, utils,
454+
# valuespecs, user_message. Collection is driven by the runfiles content
455+
# below tests/unit/cmk/gui, so no per-directory args are needed.
453456
py_cmk_test(
454457
name = "tests",
455-
srcs = glob(["test_*.py"]),
458+
srcs = glob([
459+
"test_*.py",
460+
"htmllib/**/*.py",
461+
"theme/**/*.py",
462+
"user_message/**/*.py",
463+
"utils/**/*.py",
464+
"valuespecs/**/*.py",
465+
]),
456466
args = [
457467
"tests/unit/cmk/gui",
458468
],
@@ -465,6 +475,7 @@ py_cmk_test(
465475
":conftest",
466476
"//cmk/gui:app",
467477
"//cmk/gui:auth",
478+
"//cmk/gui:auth_core",
468479
"//cmk/gui:config",
469480
"//cmk/gui:core_toolkit",
470481
"//cmk/gui:customer",
@@ -500,13 +511,15 @@ py_cmk_test(
500511
"//packages/cmk-ccc:version",
501512
"//packages/cmk-crash:crash",
502513
"//packages/cmk-crypto",
514+
"//packages/cmk-licensing",
503515
"//packages/cmk-livestatus-client",
504516
"//packages/cmk-livestatus-client:livestatus-api",
505517
"//packages/cmk-mkp-tool",
506518
"//packages/cmk-plugin-apis:graphing",
507519
"//packages/cmk-plugin-apis:inventory_ui",
508520
"//packages/cmk-trace",
509521
"//packages/cmk-wsgi",
522+
"//tests/testlib:rest_api_client",
510523
"//tests/unit:conftest",
511524
requirement("beautifulsoup4"),
512525
requirement("fido2"),

tests/unit/cmk/gui/htmllib/BUILD

Lines changed: 0 additions & 23 deletions
This file was deleted.

tests/unit/cmk/gui/theme/BUILD

Lines changed: 0 additions & 11 deletions
This file was deleted.

tests/unit/cmk/gui/user_message/BUILD

Lines changed: 0 additions & 16 deletions
This file was deleted.

tests/unit/cmk/gui/utils/BUILD

Lines changed: 0 additions & 36 deletions
This file was deleted.

tests/unit/cmk/gui/valuespecs/BUILD

Lines changed: 0 additions & 23 deletions
This file was deleted.

0 commit comments

Comments
 (0)