18194 FIX Host check command: crash when using "Use a custom check plug-in" option

When setting the "Use a custom check plug-in" option for the Host check command ruleset
and then logging in as a normal monitoring user without the permission to configure this
option, this would lead to a crash to both the UI and the REST API.

Now this option is still being display but not editable by users without permission.

SUP-23384

Change-Id: Id709889822f854f3010324944b64507828769a55

Author: loocars

.werks/18194

@@ -0,0 +1,14 @@
+Title: Host check command: crash when using "Use a custom check plug-in" option
+Class: fix
+Compatible: compat
+Component: wato
+Date: 1753255863
+Edition: cre
+Level: 1
+Version: 2.2.0p45
+
+When setting the "Use a custom check plug-in" option for the Host check command ruleset
+and then logging in as a normal monitoring user without the permission to configure this
+option, this would lead to a crash to both the UI and the REST API.
+
+Now this option is still being display but not editable by users without permission.

cmk/gui/plugins/wato/check_mk_configuration.py

@@ -3562,11 +3562,12 @@ def _host_check_commands_host_check_command_choices() -> list[CascadingDropdownC
                 ),
             ),
         ),
+        (
+            "custom",
+            _("Use a custom check plug-in..."),
+            PluginCommandLine(read_only=not user.may("wato.add_or_modify_executables")),
+        ),
     ]
-
-    if user.may("wato.add_or_modify_executables"):
-        choices.append(("custom", _("Use a custom check plugin..."), PluginCommandLine()))
-
     return choices
 
 

cmk/gui/plugins/wato/utils/__init__.py

@@ -214,8 +214,13 @@ def title(self) -> str:
         return _("Setup")
 
 
-def PluginCommandLine() -> ValueSpec:
+def PluginCommandLine(read_only: bool = False) -> ValueSpec:
     def _validate_custom_check_command_line(value, varprefix):
+        if read_only:
+            raise MKUserError(
+                varprefix,
+                _("You are not allowed to change the command line of a custom check plug-in."),
+            )
         if "--pwstore=" in value:
             raise MKUserError(
                 varprefix, _("You are not allowed to use passwords from the password store here.")
@@ -231,6 +236,7 @@ def _validate_custom_check_command_line(value, varprefix):
         )
         + monitoring_macro_help(),
         size="max",
+        read_only=read_only,
         validate=_validate_custom_check_command_line,
     )